Yingyi Bu has posted comments on this change. Change subject: Add support for persistent local resources to IndexLifecycleManager ......................................................................
Patch Set 2: (3 comments) I leave some comments in the code based on my understanding. But I could be wrong. Just correct me if I'm wrong:-) https://asterix-gerrit.ics.uci.edu/#/c/343/2/hyracks/hyracks-storage-am-common/src/main/java/edu/uci/ics/hyracks/storage/am/common/api/IIndexLifecycleManager.java File hyracks/hyracks-storage-am-common/src/main/java/edu/uci/ics/hyracks/storage/am/common/api/IIndexLifecycleManager.java: Line 34: public boolean supportsPersistentLocalResources(); s/supports/support ? Add some comments to clarify what does supportPersistentLocalResources() mean? Does it mean all the resource look-ups will be based on names if that returns true? It looks all methods are duplicated... Could the parameter be "ResourceHandle", where internally, a ResourceHandle can contain a string and long? Then, at runtime, if the long presents, use it to lookup, otherwise (or the long id doesn't find anything) use the string. https://asterix-gerrit.ics.uci.edu/#/c/343/2/hyracks/hyracks-storage-am-common/src/main/java/edu/uci/ics/hyracks/storage/am/common/api/IModificationOperationCallbackFactory.java File hyracks/hyracks-storage-am-common/src/main/java/edu/uci/ics/hyracks/storage/am/common/api/IModificationOperationCallbackFactory.java: Line 27: Object resource, IHyracksTaskContext ctx) throws HyracksDataException; Why "Object resource" is necessary here? It seems they are never used in the implementations? (It is a problem of the old code though..) https://asterix-gerrit.ics.uci.edu/#/c/343/2/hyracks/hyracks-storage-am-lsm-btree/src/main/java/edu/uci/ics/hyracks/storage/am/lsm/btree/dataflow/ExternalBTreeDataflowHelper.java File hyracks/hyracks-storage-am-lsm-btree/src/main/java/edu/uci/ics/hyracks/storage/am/lsm/btree/dataflow/ExternalBTreeDataflowHelper.java: Line 66: index = lcManager.getIndex(file.getFile().getPath()); Could the method be moved up to the super class? It looks this code is duplicated in several External*TreeDataflowHelper classes: ExternalBTreeDataflowHelper, ExternalBTreeWithBuddyDataflowHelper, and ExternalRTreeDataflowHelper.java. Also, why only those External*TreeDataFlowHelpers have this change? How about other *DataflowHelpers? -- To view, visit https://asterix-gerrit.ics.uci.edu/343 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2e8e974fc2f746959639ce94351f8e419a7f9093 Gerrit-PatchSet: 2 Gerrit-Project: hyracks Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: Young-Seok Kim <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
