Murtadha Hubail has posted comments on this change. Change subject: Add support for persistent local resources to IndexLifecycleManager ......................................................................
Patch Set 2: (4 comments) https://asterix-gerrit.ics.uci.edu/#/c/343/2/hyracks/hyracks-storage-am-common/src/main/java/edu/uci/ics/hyracks/storage/am/common/api/IIndexLifecycleManager.java File hyracks/hyracks-storage-am-common/src/main/java/edu/uci/ics/hyracks/storage/am/common/api/IIndexLifecycleManager.java: Line 34: public boolean supportsPersistentLocalResources(); > s/supports/support ? It means that its LocalResourceRepository is of type PersistentLocalResourceRepository. Line 37: > I see that your asterixdb change only uses resource names... I'm ok to onl I would like to keep the string only as well, but I don't want to remove the other methods from the interface incase some system is using them via TransientLocalResourceRepository. You may want to have a look at my discussion with Till. In both cases (Long and String), they are accessed using hashCode(), I doubt there will be performance problems. https://asterix-gerrit.ics.uci.edu/#/c/343/2/hyracks/hyracks-storage-am-common/src/main/java/edu/uci/ics/hyracks/storage/am/common/api/IModificationOperationCallbackFactory.java File hyracks/hyracks-storage-am-common/src/main/java/edu/uci/ics/hyracks/storage/am/common/api/IModificationOperationCallbackFactory.java: Line 27: Object resource, IHyracksTaskContext ctx) throws HyracksDataException; > Why "Object resource" is necessary here? Yes, I don't think it is used. https://asterix-gerrit.ics.uci.edu/#/c/343/2/hyracks/hyracks-storage-am-lsm-btree/src/main/java/edu/uci/ics/hyracks/storage/am/lsm/btree/dataflow/ExternalBTreeDataflowHelper.java File hyracks/hyracks-storage-am-lsm-btree/src/main/java/edu/uci/ics/hyracks/storage/am/lsm/btree/dataflow/ExternalBTreeDataflowHelper.java: Line 66: index = lcManager.getIndex(file.getFile().getPath()); > Could the method be moved up to the super class? Other DataflowHelpers don't override this method. Therefore, they all go thru IndexDataflowHelper. There is no super class for the External indexes, they extend the same class (AbstractLSMIndexDataflowHelper) as the internal indexes. A super class could be created for the external indexes to factor out this method. -- To view, visit https://asterix-gerrit.ics.uci.edu/343 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2e8e974fc2f746959639ce94351f8e419a7f9093 Gerrit-PatchSet: 2 Gerrit-Project: hyracks Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: Young-Seok Kim <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
