Till Westmann has posted comments on this change. Change subject: Add support for persistent local resources to IndexLifecycleManager ......................................................................
Patch Set 2: (1 comment) Ok, so the goal of the change is to avoid keeping all the mappings (ID -> resource, name -> resource) in memory. Is that right? If that's the goal, using Strings directly to identify files helps as we don't need to maintain the map. However, digging though the code some it seems (if I dug correctly) that the resource identifiers are used for logging and recovery and so it seems that we still need to maintain the ids (and it's probably a good idea to not try to serialize strings into the log). So if we didn't want to have that mapping in memory we'd need to put it somewhere else (and it probably already is somewhere else, if it's used in the log). Is that right as well (or didn't I look closely enough at the code)? In that case it seems that it'd be difficult to use strings for everything, https://asterix-gerrit.ics.uci.edu/#/c/343/2/hyracks/hyracks-storage-am-lsm-btree/src/main/java/edu/uci/ics/hyracks/storage/am/lsm/btree/dataflow/ExternalBTreeDataflowHelper.java File hyracks/hyracks-storage-am-lsm-btree/src/main/java/edu/uci/ics/hyracks/storage/am/lsm/btree/dataflow/ExternalBTreeDataflowHelper.java: Line 66: index = lcManager.getIndex(file.getFile().getPath()); > Other DataflowHelpers don't override this method. Therefore, they all go th That sounds like a good idea. Also, we could probably streamline the method a bit and reduce the number of try-catch-blocks. -- To view, visit https://asterix-gerrit.ics.uci.edu/343 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2e8e974fc2f746959639ce94351f8e419a7f9093 Gerrit-PatchSet: 2 Gerrit-Project: hyracks Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: Young-Seok Kim <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
