Yingyi Bu has posted comments on this change. Change subject: Add support for persistent local resources to IndexLifecycleManager ......................................................................
Patch Set 2: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/343/2/hyracks/hyracks-storage-am-common/src/main/java/edu/uci/ics/hyracks/storage/am/common/api/IIndexLifecycleManager.java File hyracks/hyracks-storage-am-common/src/main/java/edu/uci/ics/hyracks/storage/am/common/api/IIndexLifecycleManager.java: Line 37: > I would like to keep the string only as well, but I don't want to remove th Well, if the string presents in the map (which is the most-often case), actual string comparisons will be called. But I think that anyway shouldn't be the bottleneck of our current system --- because we haven't run thousands of lookups/updates simultaneously yet. https://asterix-gerrit.ics.uci.edu/#/c/343/2/hyracks/hyracks-storage-am-common/src/main/java/edu/uci/ics/hyracks/storage/am/common/api/IModificationOperationCallbackFactory.java File hyracks/hyracks-storage-am-common/src/main/java/edu/uci/ics/hyracks/storage/am/common/api/IModificationOperationCallbackFactory.java: Line 27: Object resource, IHyracksTaskContext ctx) throws HyracksDataException; > Yes, I don't think it is used. OK, i'm fine to keep that in the current CL and maybe we can remove that in a future CL. -- To view, visit https://asterix-gerrit.ics.uci.edu/343 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2e8e974fc2f746959639ce94351f8e419a7f9093 Gerrit-PatchSet: 2 Gerrit-Project: hyracks Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: Young-Seok Kim <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
