Till Westmann has posted comments on this change. Change subject: Add support for persistent local resources to IndexLifecycleManager ......................................................................
Patch Set 3: Code-Review+1 (6 comments) Look much better now (and I learned a lot), thanks! My only remaining comments are about small code cleanups that would make things a littler easier to read (at least for me). I'll leave the question about other users of the interface to Yingyi. https://asterix-gerrit.ics.uci.edu/#/c/343/3/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/dataflow/IndexDataflowHelper.java File hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/dataflow/IndexDataflowHelper.java: Line 71: long resourceID = getResourceID(); Could we move the declaration of resourceID down to the place it is actually needed (inside the try-block)? Line 73: index = lcManager.getIndex(file.getFile().getPath()); Could we create a local variable for "file.getFile().getPath()"? Line 104: long resourceID = getResourceID(); Maybe we can inline resourceID? Line 110: index = lcManager.getIndex(file.getFile().getPath()); Could we create a local variable for "file.getFile().getPath()"? Line 130: index = lcManager.getIndex(file.getFile().getPath()); Could we create a local variable for "file.getFile().getPath()"? https://asterix-gerrit.ics.uci.edu/#/c/343/3/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/dataflow/IndexLifecycleManager.java File hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/dataflow/IndexLifecycleManager.java: Line 253: return lr.getResourceId(); return lr == null ? -1 : lr.getResourceId() ? :) -- To view, visit https://asterix-gerrit.ics.uci.edu/343 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2e8e974fc2f746959639ce94351f8e419a7f9093 Gerrit-PatchSet: 3 Gerrit-Project: hyracks Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: Young-Seok Kim <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
