----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65033/#review195026 -----------------------------------------------------------
docs/src/site/twiki/Search-Advanced.twiki Lines 21 (patched) <https://reviews.apache.org/r/65033/#comment274147> typo: Advanced docs/src/site/twiki/Search-Advanced.twiki Lines 36 (patched) <https://reviews.apache.org/r/65033/#comment274138> Perhaps we should say that the default is that no 'where' filtering takes place and the default select behaviour is that the query returns everything? docs/src/site/twiki/Search-Advanced.twiki Lines 39 (patched) <https://reviews.apache.org/r/65033/#comment274137> It seems that classifications are an example of a where clause (whether explicit or not) - is that correct? It might be better to do some simple from where select examples before getting into classifications? docs/src/site/twiki/Search-Advanced.twiki Lines 68 (patched) <https://reviews.apache.org/r/65033/#comment274142> Is there a way for the user composing the query to find out what properties are available in the type? docs/src/site/twiki/Search-Advanced.twiki Lines 135 (patched) <https://reviews.apache.org/r/65033/#comment274139> Is there a way to override this auto-limiting behaviour - what f the user wanted to get all the results (in a script for example)? docs/src/site/twiki/Search-Advanced.twiki Lines 181 (patched) <https://reviews.apache.org/r/65033/#comment274140> This returns the oldest createTime. docs/src/site/twiki/Search-Advanced.twiki Lines 193 (patched) <https://reviews.apache.org/r/65033/#comment274141> This is confusing - why do we need the groupby as well as the aggregation function in the select clause? docs/src/site/twiki/Search-Advanced.twiki Lines 214 (patched) <https://reviews.apache.org/r/65033/#comment274143> Seems like unnecessary detail at this level of documentation. Same comment applies to other edge direction commentary below. docs/src/site/twiki/Search-Advanced.twiki Lines 230 (patched) <https://reviews.apache.org/r/65033/#comment274144> Can we drop the 'v2' part of the URL path before we release Atlas 1.0.0? It should not be confused with the V1 API because that uses the 'discovery' path. docs/src/site/twiki/Search-Advanced.twiki Lines 257 (patched) <https://reviews.apache.org/r/65033/#comment274145> Does this get removed in 1.0.0? docs/src/site/twiki/Search-Advanced.twiki Lines 288 (patched) <https://reviews.apache.org/r/65033/#comment274146> typo: generated by docs/src/site/twiki/Search-Advanced.twiki Lines 291 (patched) <https://reviews.apache.org/r/65033/#comment274148> typo: clauses are no longer supported docs/src/site/twiki/Search-Basic.twiki Lines 31 (patched) <https://reviews.apache.org/r/65033/#comment274149> This is not clear. - Graham Wallis On Jan. 8, 2018, 10:49 p.m., Ashutosh Mestry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65033/ > ----------------------------------------------------------- > > (Updated Jan. 8, 2018, 10:49 p.m.) > > > Review request for atlas and Apoorv Naik. > > > Bugs: ATLAS-2229 > https://issues.apache.org/jira/browse/ATLAS-2229 > > > Repository: atlas > > > Description > ------- > > **Background** > The Advanced Search (DSL) documentation has been updated. > > This includes: > * Example-based approach to write-up. > * Minor variations in the current version. > > **Approach** > Separated _Basic Search_ and _Advanced Search_ to individual pages. > > > Diffs > ----- > > docs/src/site/twiki/Search-Advanced.twiki PRE-CREATION > docs/src/site/twiki/Search-Basic.twiki PRE-CREATION > docs/src/site/twiki/Search.twiki 6d174084 > docs/src/site/twiki/index.twiki a8e7de9f > > > Diff: https://reviews.apache.org/r/65033/diff/1/ > > > Testing > ------- > > **Testing** > Using _mvn site:run_ > > > Thanks, > > Ashutosh Mestry > >
