> On Jan. 9, 2018, 12:16 p.m., Graham Wallis wrote: > >
Thanks for the review. I have tried to address most of the review comments. Few items I have dropped not because they were not valuable but only because I thought that they were not in scope of this exercise. > On Jan. 9, 2018, 12:16 p.m., Graham Wallis wrote: > > docs/src/site/twiki/Search-Advanced.twiki > > Lines 39 (patched) > > <https://reviews.apache.org/r/65033/diff/1/?file=1936213#file1936213line39> > > > > It seems that classifications are an example of a where clause (whether > > explicit or not) - is that correct? It might be better to do some simple > > from where select examples before getting into classifications? Makes sense. I will move this section further down. > On Jan. 9, 2018, 12:16 p.m., Graham Wallis wrote: > > docs/src/site/twiki/Search-Advanced.twiki > > Lines 68 (patched) > > <https://reviews.apache.org/r/65033/diff/1/?file=1936213#file1936213line68> > > > > Is there a way for the user composing the query to find out what > > properties are available in the type? Right now, there isn't. The only way I can think of is to open the entity in the UI and look at the properties or be aware of the model. I would be useful if we had a type-ahead suggestion support within the search box. Also, it will help the user if there search box was wider. > On Jan. 9, 2018, 12:16 p.m., Graham Wallis wrote: > > docs/src/site/twiki/Search-Advanced.twiki > > Lines 135 (patched) > > <https://reviews.apache.org/r/65033/diff/1/?file=1936213#file1936213line135> > > > > Is there a way to override this auto-limiting behaviour - what f the > > user wanted to get all the results (in a script for example)? It is possible to do this by specifying a large number in limit. We handle this 'smartly' by fetching 25 results at a time and then allowing the user to page through the results in the UI. If same query is issued via REST call, all the results will be fetched. But there is no default non-limit. > On Jan. 9, 2018, 12:16 p.m., Graham Wallis wrote: > > docs/src/site/twiki/Search-Advanced.twiki > > Lines 193 (patched) > > <https://reviews.apache.org/r/65033/diff/1/?file=1936213#file1936213line193> > > > > This is confusing - why do we need the groupby as well as the > > aggregation function in the select clause? I am not sure what the motivation was when the language was developed. There I have in my tests where it seems to make sense. > On Jan. 9, 2018, 12:16 p.m., Graham Wallis wrote: > > docs/src/site/twiki/Search-Advanced.twiki > > Lines 214 (patched) > > <https://reviews.apache.org/r/65033/diff/1/?file=1936213#file1936213line214> > > > > Seems like unnecessary detail at this level of documentation. Same > > comment applies to other edge direction commentary below. I will remove this. > On Jan. 9, 2018, 12:16 p.m., Graham Wallis wrote: > > docs/src/site/twiki/Search-Advanced.twiki > > Lines 230 (patched) > > <https://reviews.apache.org/r/65033/diff/1/?file=1936213#file1936213line230> > > > > Can we drop the 'v2' part of the URL path before we release Atlas > > 1.0.0? It should not be confused with the V1 API because that uses the > > 'discovery' path. Good point. I will discuss this internally. > On Jan. 9, 2018, 12:16 p.m., Graham Wallis wrote: > > docs/src/site/twiki/Search-Advanced.twiki > > Lines 257 (patched) > > <https://reviews.apache.org/r/65033/diff/1/?file=1936213#file1936213line257> > > > > Does this get removed in 1.0.0? This continues to exist as an enpoint. The calls execute the same code thru both APIs. > On Jan. 9, 2018, 12:16 p.m., Graham Wallis wrote: > > docs/src/site/twiki/Search-Basic.twiki > > Lines 31 (patched) > > <https://reviews.apache.org/r/65033/diff/1/?file=1936214#file1936214line31> > > > > This is not clear. I have not changed this. I simple separated the 2 sections (basic and advanced) to make more room for my write-up on Advanced search. - Ashutosh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65033/#review195026 ----------------------------------------------------------- On Jan. 10, 2018, 12:45 a.m., Ashutosh Mestry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65033/ > ----------------------------------------------------------- > > (Updated Jan. 10, 2018, 12:45 a.m.) > > > Review request for atlas, Apoorv Naik and Graham Wallis. > > > Bugs: ATLAS-2229 > https://issues.apache.org/jira/browse/ATLAS-2229 > > > Repository: atlas > > > Description > ------- > > **Background** > The Advanced Search (DSL) documentation has been updated. > > This includes: > * Example-based approach to write-up. > * Minor variations in the current version. > > **Approach** > Separated _Basic Search_ and _Advanced Search_ to individual pages. > > **Site Run Port** > Modified site:run port to point to 8888. This allows for use of Atlas > application on VM and also develop documentation. > > > Diffs > ----- > > docs/src/site/twiki/Search-Advanced.twiki PRE-CREATION > docs/src/site/twiki/Search-Basic.twiki PRE-CREATION > docs/src/site/twiki/Search.twiki 6d174084 > docs/src/site/twiki/index.twiki a8e7de9f > pom.xml 203c4b0d > > > Diff: https://reviews.apache.org/r/65033/diff/2/ > > > Testing > ------- > > **Testing** > Using _mvn site:run_ (now uses port 8888). > > > Thanks, > > Ashutosh Mestry > >
