> On Jan. 31, 2018, 6:40 p.m., Apoorv Naik wrote: > > docs/src/site/twiki/Search-Advanced.twiki > > Lines 58 (patched) > > <https://reviews.apache.org/r/65033/diff/4/?file=1950677#file1950677line58> > > > > Do we support IN clause for this case ?
We have this already. We use 'has' and 'within'. > On Jan. 31, 2018, 6:40 p.m., Apoorv Naik wrote: > > docs/src/site/twiki/Search-Advanced.twiki > > Lines 212 (patched) > > <https://reviews.apache.org/r/65033/diff/4/?file=1950677#file1950677line212> > > > > This seems misleading/confusing, I interpret this as "GroupBy should > > always be accompanied by a select" whereas the prior example is a simple > > groupBy w/o select. Otherway round actually. > On Jan. 31, 2018, 6:40 p.m., Apoorv Naik wrote: > > docs/src/site/twiki/Search-Advanced.twiki > > Lines 292 (patched) > > <https://reviews.apache.org/r/65033/diff/4/?file=1950677#file1950677line292> > > > > Typo: AtlasBaeExecption Fixed. > On Jan. 31, 2018, 6:40 p.m., Apoorv Naik wrote: > > docs/src/site/twiki/Search-Advanced.twiki > > Lines 344 (patched) > > <https://reviews.apache.org/r/65033/diff/4/?file=1950677#file1950677line344> > > > > Wasn't this fixed in a recent commit. Yes, indeed. - Ashutosh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65033/#review196573 ----------------------------------------------------------- On Jan. 31, 2018, 6:34 a.m., Ashutosh Mestry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65033/ > ----------------------------------------------------------- > > (Updated Jan. 31, 2018, 6:34 a.m.) > > > Review request for atlas, Apoorv Naik and Graham Wallis. > > > Bugs: ATLAS-2229 > https://issues.apache.org/jira/browse/ATLAS-2229 > > > Repository: atlas > > > Description > ------- > > **Background** > The Advanced Search (DSL) documentation has been updated. > > This includes: > * Example-based approach to write-up. > * Minor variations in the current version. > > **Approach** > Separated _Basic Search_ and _Advanced Search_ to individual pages. > > **Site Run Port** > Modified site:run port to point to 8888. This allows for use of Atlas > application on VM and also develop documentation. > > > Diffs > ----- > > docs/pom.xml 770aaf84 > docs/src/site/twiki/Search-Advanced.twiki PRE-CREATION > docs/src/site/twiki/Search-Basic.twiki PRE-CREATION > docs/src/site/twiki/Search.twiki 6d174084 > docs/src/site/twiki/index.twiki 57d5b8ab > > > Diff: https://reviews.apache.org/r/65033/diff/4/ > > > Testing > ------- > > **Testing** > Using _mvn site:run_ (now uses port 8888). > URL: http://localhost:8888/Search-Advanced.html > > > Thanks, > > Ashutosh Mestry > >
