----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65033/#review196573 -----------------------------------------------------------
docs/src/site/twiki/Search-Advanced.twiki Lines 27 (patched) <https://reviews.apache.org/r/65033/#comment276281> Might be a good idea to put the Atlas grammar reference here, so that any potential user can familiarize themselves with the syntax docs/src/site/twiki/Search-Advanced.twiki Lines 52 (patched) <https://reviews.apache.org/r/65033/#comment276278> Add note that ORs on same attribute will be inefficient and the workaround is using the valueArray type construct that follows. eg. Table where name = ['x','t'] docs/src/site/twiki/Search-Advanced.twiki Lines 58 (patched) <https://reviews.apache.org/r/65033/#comment276277> Do we support IN clause for this case ? docs/src/site/twiki/Search-Advanced.twiki Lines 60 (patched) <https://reviews.apache.org/r/65033/#comment276273> Might be worth adding few more regex examples and if possible add negative usecases as well, so that end-user is made aware of what works beforehand. docs/src/site/twiki/Search-Advanced.twiki Lines 62 (patched) <https://reviews.apache.org/r/65033/#comment276272> ends with '_dim' docs/src/site/twiki/Search-Advanced.twiki Lines 98 (patched) <https://reviews.apache.org/r/65033/#comment276276> Please add note that select can only work with following combinations 1. all immediate attributes 2. immediate attribute + aggregation on immediate attribute 3. referred attributes can't be mixed, if select has referred attributes then they must belong to same referred type eg. Table where name='foo' select DB.name, DB.owner docs/src/site/twiki/Search-Advanced.twiki Lines 156 (patched) <https://reviews.apache.org/r/65033/#comment276279> Please add a note that ordering has to be done on immediate attributes. docs/src/site/twiki/Search-Advanced.twiki Lines 160 (patched) <https://reviews.apache.org/r/65033/#comment276280> What's the default order of the results ? docs/src/site/twiki/Search-Advanced.twiki Lines 168 (patched) <https://reviews.apache.org/r/65033/#comment276275> Please add a note that aggregates will only work with immediate attributes and not on a referred attributes. docs/src/site/twiki/Search-Advanced.twiki Lines 212 (patched) <https://reviews.apache.org/r/65033/#comment276274> This seems misleading/confusing, I interpret this as "GroupBy should always be accompanied by a select" whereas the prior example is a simple groupBy w/o select. docs/src/site/twiki/Search-Advanced.twiki Lines 292 (patched) <https://reviews.apache.org/r/65033/#comment276268> Typo: AtlasBaeExecption docs/src/site/twiki/Search-Advanced.twiki Lines 307 (patched) <https://reviews.apache.org/r/65033/#comment276269> I think we should not even specify the V1 references to avoid any confusion for the end user. Let's keep all DSL references pointing to V2 endpoints. docs/src/site/twiki/Search-Advanced.twiki Lines 337 (patched) <https://reviews.apache.org/r/65033/#comment276271> Typo: Generted docs/src/site/twiki/Search-Advanced.twiki Lines 344 (patched) <https://reviews.apache.org/r/65033/#comment276270> Wasn't this fixed in a recent commit. - Apoorv Naik On Jan. 31, 2018, 6:34 a.m., Ashutosh Mestry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65033/ > ----------------------------------------------------------- > > (Updated Jan. 31, 2018, 6:34 a.m.) > > > Review request for atlas, Apoorv Naik and Graham Wallis. > > > Bugs: ATLAS-2229 > https://issues.apache.org/jira/browse/ATLAS-2229 > > > Repository: atlas > > > Description > ------- > > **Background** > The Advanced Search (DSL) documentation has been updated. > > This includes: > * Example-based approach to write-up. > * Minor variations in the current version. > > **Approach** > Separated _Basic Search_ and _Advanced Search_ to individual pages. > > **Site Run Port** > Modified site:run port to point to 8888. This allows for use of Atlas > application on VM and also develop documentation. > > > Diffs > ----- > > docs/pom.xml 770aaf84 > docs/src/site/twiki/Search-Advanced.twiki PRE-CREATION > docs/src/site/twiki/Search-Basic.twiki PRE-CREATION > docs/src/site/twiki/Search.twiki 6d174084 > docs/src/site/twiki/index.twiki 57d5b8ab > > > Diff: https://reviews.apache.org/r/65033/diff/4/ > > > Testing > ------- > > **Testing** > Using _mvn site:run_ (now uses port 8888). > URL: http://localhost:8888/Search-Advanced.html > > > Thanks, > > Ashutosh Mestry > >
