----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65123/ -----------------------------------------------------------
(Updated Jan. 29, 2018, 3:40 p.m.) Review request for atlas and Mandy Chessell. Changes ------- update the patch based on the reviews Summary (updated) ----------------- ATLAS-2298 - Review of OCF Database Connector Repository: atlas Description (updated) ------- The OCF Database Connector is the subclass of OCF Connector and it is designed especially for connection to database to retrieve data. Here we implement a connector for Gaian (GaianOCFConnector) as an example for using OCF Database Connector. It is related to Open Connector Framework. The JIRA can be found https://issues.apache.org/jira/browse/ATLAS-2298 Diffs (updated) ----- ocfdb/README.md PRE-CREATION ocfdb/pom.xml PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocf/Connector.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocf/ConnectorBase.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocf/ConnectorBroker.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocf/ConnectorProvider.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocf/ConnectorProviderBase.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocf/ffdc/ConnectionCheckedException.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocf/ffdc/ConnectorCheckedException.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocf/ffdc/OCFCheckedExceptionBase.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocf/ffdc/OCFErrorCode.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocf/ffdc/OCFRuntimeException.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocf/ffdc/PropertyServerException.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocf/ffdc/README.md PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocf/properties/AdditionalProperties.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocf/properties/Annotation.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocf/properties/AnnotationStatus.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocf/properties/Annotations.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocf/properties/AssetDescriptor.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocf/properties/AssetDetail.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocf/properties/AssetPropertyBase.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocf/properties/AssetPropertyIteratorBase.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocf/properties/AssetSummary.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocf/properties/AssetUniverse.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocf/properties/Certification.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocf/properties/Certifications.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocf/properties/Classification.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocf/properties/Classifications.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocf/properties/Comment.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocf/properties/CommentType.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocf/properties/Comments.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocf/properties/ConnectedAssetProperties.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocf/properties/Connection.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocf/properties/Connections.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocf/properties/ConnectorType.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocf/properties/DerivedSchemaElement.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocf/properties/ElementHeader.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocf/properties/ElementOrigin.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocf/properties/ElementType.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocf/properties/EmbeddedConnection.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocf/properties/EmbeddedConnections.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocf/properties/Endpoint.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocf/properties/ExternalIdentifier.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocf/properties/ExternalIdentifiers.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocf/properties/ExternalReference.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocf/properties/ExternalReferences.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocf/properties/Feedback.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocf/properties/InformalTag.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocf/properties/InformalTags.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocf/properties/KeyPattern.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocf/properties/License.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocf/properties/Licenses.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocf/properties/Like.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocf/properties/Likes.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocf/properties/Lineage.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocf/properties/Location.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocf/properties/Locations.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocf/properties/MapSchemaElement.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocf/properties/Meaning.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocf/properties/Meanings.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocf/properties/Note.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocf/properties/NoteLog.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocf/properties/NoteLogs.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocf/properties/Notes.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocf/properties/PagingIterator.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocf/properties/PrimitiveSchemaElement.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocf/properties/PropertyBase.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocf/properties/Rating.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocf/properties/Ratings.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocf/properties/Referenceable.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocf/properties/RelatedAsset.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocf/properties/RelatedAssetProperties.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocf/properties/RelatedAssets.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocf/properties/RelatedMediaReference.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocf/properties/RelatedMediaReferences.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocf/properties/RelatedMediaType.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocf/properties/RelatedMediaUsage.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocf/properties/Schema.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocf/properties/SchemaAttribute.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocf/properties/SchemaAttributes.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocf/properties/SchemaElement.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocf/properties/SchemaImplementationQueries.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocf/properties/SchemaImplementationQuery.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocf/properties/SchemaLink.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocf/properties/SchemaLinks.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocf/properties/SchemaType.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocf/properties/StarRating.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocf/properties/VirtualConnection.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocfdb/connectors/OCFDataProvider.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocfdb/connectors/OCFDatabaseConnection.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocfdb/connectors/OCFDatabaseConnector.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocfdb/connectors/OCFDatabaseConnectorProviderBase.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocfdb/connectors/gaian/GaianOCFConnector.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocfdb/connectors/gaian/GaianOCFConnectorProvider.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocfdb/ffdc/DatabaseAccessCheckedException.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocfdb/ffdc/OCFDatabaseCheckedExceptionBase.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocfdb/ffdc/OCFDatabaseConnectorErrorCode.java PRE-CREATION ocfdb/src/main/java/org/apache/atlas/ocfdb/ffdc/OCFDatabaseConnectorRuntimeException.java PRE-CREATION ocfdb/src/test/java/AB.java PRE-CREATION ocfdb/src/test/java/Parent.java PRE-CREATION ocfdb/src/test/java/testPagingIterator.java PRE-CREATION Diff: https://reviews.apache.org/r/65123/diff/3/ Changes: https://reviews.apache.org/r/65123/diff/2-3/ Testing ------- create an instance of the Connector and use getData() function. Gaian has to be set up in advance. File Attachments (updated) ---------------- ATLAS-2298-update-patch-based-on-reviews.patch https://reviews.apache.org/media/uploaded/files/2018/01/29/e228728b-3ac4-49a9-8b44-bb3ff2a04052__ATLAS-2298-update-patch-based-on-reviews.patch Thanks, Yao Li
