[
https://issues.apache.org/jira/browse/AVRO-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16640949#comment-16640949
]
ASF GitHub Bot commented on AVRO-1887:
--------------------------------------
Fokko opened a new pull request #344: [AVRO-1887][WIP] Setup precommit hooks
using Apache Yetus
URL: https://github.com/apache/avro/pull/344
Based on the earlier work of @spacharya
The current configuration does not kick off the tests:
```
| Vote | Subsystem | Runtime | Comment
============================================================================
| 0 | reexec | 0m 9s | Docker mode activated.
| | | | Prechecks
| 0 | shelldocs | 0m 25s | Shelldocs was not available.
| | | | Compile Tests
| -1 | @author | 0m 46s | The source tree appears to contain 4
| | | | @author tags which the community has
| | | | agreed to not allow in code
| | | | contributions.
| -1 | hadolint | 0m 1s | The source tree has 4 issues.
| -1 | perlcritic | 0m 13s | The source tree has 456 issues.
| -1 | pylint | 2m 14s | The source tree has 7623 issues.
| -1 | rubocop | 0m 28s | The source tree has 1053 issues.
| -1 | ruby-lint | 0m 15s | The source tree has 885 issues.
| -1 | shellcheck | 0m 3s | The source tree has 126 issues.
| -1 | whitespace | 0m 3s | The source tree has 1229 line(s) that
| | | | end in whitespace.
| -1 | whitespace | 0m 14s | The source tree 22503 line(s) with
tabs.
| -1 | xml | 1m 40s | The source tree has 9 ill-formed XML
| | | | file(s).
| +1 | buildtest | 0m 0s | the source passed
| | | | Other Tests
| | | 9m 22s |
```
The buildstep `buildtest` takes `0m 0s`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> set up precommit checks via Apache Yetus
> ----------------------------------------
>
> Key: AVRO-1887
> URL: https://issues.apache.org/jira/browse/AVRO-1887
> Project: Avro
> Issue Type: Task
> Components: build, community
> Reporter: Sean Busbey
> Assignee: Suraj Acharya
> Priority: Blocker
> Attachments: AVRO-1887-0.patch, AVRO-1887-1.patch, AVRO-1887-2.patch
>
>
> The lack of automated checks for things like doing a full build is negatively
> impacting my ability to do timely reviews. We should leverage the work done
> by other communities and get precommit checks going with Apache Yetus ([ref
> Apache Yetus
> Precommit|http://yetus.apache.org/documentation/0.3.0/precommit-basic/])
> Yetus has built in support for using Docker as a containerized build
> environment ([ref
> docs|https://yetus.apache.org/documentation/0.3.0/precommit-advanced/#Docker_Support]),
> but I don't know if we can use the one we have directly or if we'll need to
> do some refactoring.
> Implementing this will ultimately require a committer (so that they can make
> changes to builds.apache.org), but a non-cmmitter can get the bulk of the
> work done by managing to do local yetus checks with the docker feature active.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
