[
https://issues.apache.org/jira/browse/AVRO-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16664006#comment-16664006
]
ASF GitHub Bot commented on AVRO-1887:
--------------------------------------
cutting commented on a change in pull request #353: AVRO-1887 Integrate Yetus
URL: https://github.com/apache/avro/pull/353#discussion_r228252951
##########
File path: lang/java/ipc/src/test/java/org/apache/avro/DataFileInteropTest.java
##########
@@ -40,27 +40,27 @@ public static void printDir() {
+ DATAFILE_DIR.getAbsolutePath());
}
- @Test
- public void testGeneratedGeneric() throws IOException {
- System.out.println("Reading with generic:");
- DatumReaderProvider<Object> provider = new DatumReaderProvider<Object>() {
- @Override public DatumReader<Object> get() {
- return new GenericDatumReader<>();
- }
- };
- readFiles(provider);
- }
-
- @Test
- public void testGeneratedSpecific() throws IOException {
- System.out.println("Reading with specific:");
- DatumReaderProvider<Interop> provider = new DatumReaderProvider<Interop>()
{
- @Override public DatumReader<Interop> get() {
- return new SpecificDatumReader<>();
- }
- };
- readFiles(provider);
- }
+ // @Test
Review comment:
Why are these commented out? Are they failing? If they're no longer
required then we should just delete them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> set up precommit checks via Apache Yetus
> ----------------------------------------
>
> Key: AVRO-1887
> URL: https://issues.apache.org/jira/browse/AVRO-1887
> Project: Avro
> Issue Type: Task
> Components: build, community
> Reporter: Sean Busbey
> Assignee: Suraj Acharya
> Priority: Blocker
> Attachments: AVRO-1887-0.patch, AVRO-1887-1.patch, AVRO-1887-2.patch
>
>
> The lack of automated checks for things like doing a full build is negatively
> impacting my ability to do timely reviews. We should leverage the work done
> by other communities and get precommit checks going with Apache Yetus ([ref
> Apache Yetus
> Precommit|http://yetus.apache.org/documentation/0.3.0/precommit-basic/])
> Yetus has built in support for using Docker as a containerized build
> environment ([ref
> docs|https://yetus.apache.org/documentation/0.3.0/precommit-advanced/#Docker_Support]),
> but I don't know if we can use the one we have directly or if we'll need to
> do some refactoring.
> Implementing this will ultimately require a committer (so that they can make
> changes to builds.apache.org), but a non-cmmitter can get the bulk of the
> work done by managing to do local yetus checks with the docker feature active.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
