[
https://issues.apache.org/jira/browse/AVRO-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16646676#comment-16646676
]
ASF GitHub Bot commented on AVRO-1887:
--------------------------------------
Fokko commented on issue #344: [AVRO-1887][WIP] Setup precommit hooks using
Apache Yetus
URL: https://github.com/apache/avro/pull/344#issuecomment-429012884
@busbey I've got a first version of the Apache Yetus script working. It took
me a while since it is new to me, so be gentle on the review ;)
I've written a small plugin that will locate all the `build.sh` scripts, and
subsequently invoke the `test` step. I know this is still a bit crude, but this
allows us to reuse the existing build scripts.
Please note that the tests are still failing, but I'm working on patches in
a new PR.
```
_____ _ _ _
| ___|_ _(_) |_ _ _ __ ___| |
| |_ / _` | | | | | | '__/ _ \ |
| _| (_| | | | |_| | | | __/_|
|_| \__,_|_|_|\__,_|_| \___(_)
| Vote | Subsystem | Runtime | Comment
============================================================================
| 0 | reexec | 0m 9s | Docker mode activated.
| | | | Prechecks
| | | | Compile Tests
| -1 | buildtest | 14m 46s | The testsuite failed, please check the
| | | | output
| | | | Other Tests
| | | 14m 55s |
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> set up precommit checks via Apache Yetus
> ----------------------------------------
>
> Key: AVRO-1887
> URL: https://issues.apache.org/jira/browse/AVRO-1887
> Project: Avro
> Issue Type: Task
> Components: build, community
> Reporter: Sean Busbey
> Assignee: Suraj Acharya
> Priority: Blocker
> Attachments: AVRO-1887-0.patch, AVRO-1887-1.patch, AVRO-1887-2.patch
>
>
> The lack of automated checks for things like doing a full build is negatively
> impacting my ability to do timely reviews. We should leverage the work done
> by other communities and get precommit checks going with Apache Yetus ([ref
> Apache Yetus
> Precommit|http://yetus.apache.org/documentation/0.3.0/precommit-basic/])
> Yetus has built in support for using Docker as a containerized build
> environment ([ref
> docs|https://yetus.apache.org/documentation/0.3.0/precommit-advanced/#Docker_Support]),
> but I don't know if we can use the one we have directly or if we'll need to
> do some refactoring.
> Implementing this will ultimately require a committer (so that they can make
> changes to builds.apache.org), but a non-cmmitter can get the bulk of the
> work done by managing to do local yetus checks with the docker feature active.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
