[
https://issues.apache.org/jira/browse/AVRO-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16665085#comment-16665085
]
ASF GitHub Bot commented on AVRO-1887:
--------------------------------------
Fokko commented on a change in pull request #353: AVRO-1887 Integrate Yetus
URL: https://github.com/apache/avro/pull/353#discussion_r228501492
##########
File path: build.sh
##########
@@ -41,11 +41,13 @@ do
# run lang-specific tests
(cd lang/java; ./build.sh test)
# install java artifacts required by other builds and interop tests
- mvn install -DskipTests
+ mvn -B install -DskipTests
(cd lang/py; ./build.sh test)
(cd lang/py3; ./build.sh test)
(cd lang/c; ./build.sh test)
- (cd lang/c++; ./build.sh test)
+ # The C++ tests are failing
+ # https://issues.apache.org/jira/projects/AVRO/issues/AVRO-2230
Review comment:
Still failing :'(
```
Scanning dependencies of target avrocpp_s
[ 1%] Building CXX object CMakeFiles/avrocpp_s.dir/impl/Compiler.cc.o
/testptch/unknown/lang/c++/impl/Compiler.cc:174:15: warning: ‘std::string
avro::nameof(const NodePtr&)’ defined but not used [-Wunused-function]
static string nameof(const NodePtr& n)
^
[ 2%] Building CXX object CMakeFiles/avrocpp_s.dir/impl/Node.cc.o
[ 4%] Building CXX object CMakeFiles/avrocpp_s.dir/impl/NodeImpl.cc.o
/testptch/unknown/lang/c++/impl/NodeImpl.cc: In function ‘std::string
avro::{anonymous}::escape(const string&)’:
/testptch/unknown/lang/c++/impl/NodeImpl.cc:31:8: warning: ‘auto’
changes meaning in C++11; please remove it [-Wc++0x-compat]
for (auto c : unescaped) {
^
/testptch/unknown/lang/c++/impl/NodeImpl.cc:31:13: error: ‘c’ does not
name a type
for (auto c : unescaped) {
^
/testptch/unknown/lang/c++/impl/NodeImpl.cc:67:3: error: expected ‘;’
before ‘return’
return s;
^
/testptch/unknown/lang/c++/impl/NodeImpl.cc:67:3: error: expected
primary-expression before ‘return’
/testptch/unknown/lang/c++/impl/NodeImpl.cc:67:3: error: expected ‘;’
before ‘return’
/testptch/unknown/lang/c++/impl/NodeImpl.cc:67:3: error: expected
primary-expression before ‘return’
/testptch/unknown/lang/c++/impl/NodeImpl.cc:67:3: error: expected ‘)’
before ‘return’
In file included from /usr/include/boost/assert.hpp:51:0,
from /usr/include/boost/format/parsing.hpp:21,
from /usr/include/boost/format.hpp:50,
from /testptch/unknown/lang/c++/api/Exception.hh:24,
from /testptch/unknown/lang/c++/api/Node.hh:28,
from /testptch/unknown/lang/c++/api/GenericDatum.hh:29,
from /testptch/unknown/lang/c++/api/NodeImpl.hh:23,
from /testptch/unknown/lang/c++/impl/NodeImpl.cc:21:
/testptch/unknown/lang/c++/impl/NodeImpl.cc: In member function ‘virtual
void avro::NodeRecord::printJson(std::ostream&, int) const’:
/testptch/unknown/lang/c++/impl/NodeImpl.cc:247:59: warning: comparison
between signed and unsigned integer expressions [-Wsign-compare]
assert(defaultValues.empty() || (defaultValues.size() == fields));
^
/testptch/unknown/lang/c++/impl/NodeImpl.cc: In member function ‘virtual
void avro::NodePrimitive::printDefaultToJson(const avro::GenericDatum&,
std::ostream&, int) const’:
/testptch/unknown/lang/c++/impl/NodeImpl.cc:292:13: error: ‘to_string’
is not a member of ‘std’
os << std::to_string(g.value<float>());
^
/testptch/unknown/lang/c++/impl/NodeImpl.cc:295:13: error: ‘to_string’
is not a member of ‘std’
os << std::to_string(g.value<double>());
^
/testptch/unknown/lang/c++/impl/NodeImpl.cc: In function ‘std::string
avro::{anonymous}::escape(const string&)’:
/testptch/unknown/lang/c++/impl/NodeImpl.cc:68:1: warning: control reaches
end of non-void function [-Wreturn-type]
}
^
CMakeFiles/avrocpp_s.dir/build.make:100: recipe for target
'CMakeFiles/avrocpp_s.dir/impl/NodeImpl.cc.o' failed
make[2]: *** [CMakeFiles/avrocpp_s.dir/impl/NodeImpl.cc.o] Error 1
make[1]: *** [CMakeFiles/avrocpp_s.dir/all] Error 2
CMakeFiles/Makefile2:425: recipe for target 'CMakeFiles/avrocpp_s.dir/all'
failed
make: *** [all] Error 2
Makefile:147: recipe for target 'all' failed
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> set up precommit checks via Apache Yetus
> ----------------------------------------
>
> Key: AVRO-1887
> URL: https://issues.apache.org/jira/browse/AVRO-1887
> Project: Avro
> Issue Type: Task
> Components: build, community
> Reporter: Sean Busbey
> Assignee: Suraj Acharya
> Priority: Blocker
> Attachments: AVRO-1887-0.patch, AVRO-1887-1.patch, AVRO-1887-2.patch
>
>
> The lack of automated checks for things like doing a full build is negatively
> impacting my ability to do timely reviews. We should leverage the work done
> by other communities and get precommit checks going with Apache Yetus ([ref
> Apache Yetus
> Precommit|http://yetus.apache.org/documentation/0.3.0/precommit-basic/])
> Yetus has built in support for using Docker as a containerized build
> environment ([ref
> docs|https://yetus.apache.org/documentation/0.3.0/precommit-advanced/#Docker_Support]),
> but I don't know if we can use the one we have directly or if we'll need to
> do some refactoring.
> Implementing this will ultimately require a committer (so that they can make
> changes to builds.apache.org), but a non-cmmitter can get the bulk of the
> work done by managing to do local yetus checks with the docker feature active.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
