[
https://issues.apache.org/jira/browse/AVRO-3453?focusedWorklogId=745223&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-745223
]
ASF GitHub Bot logged work on AVRO-3453:
----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Mar/22 16:33
Start Date: 21/Mar/22 16:33
Worklog Time Spent: 10m
Work Description: zcsizmadia commented on a change in pull request #1605:
URL: https://github.com/apache/avro/pull/1605#discussion_r831309637
##########
File path: lang/csharp/src/apache/test/AvroGen/AvroGenHelper.cs
##########
@@ -97,16 +97,20 @@ public static Assembly
CompileCSharpFilesIntoLibrary(IEnumerable<string> sourceF
Path.Combine(assemblyPath, "netstandard.dll")
};
+#if NETCOREAPP3_1
Review comment:
I prefer to have this in the assemblies List initialization all the
time, not just NETCOREAPP. If it is a dependecny, it should be in the
assemblies list. NET5.0 and NET6.0 it will be `System.Private.CoreLib.dll`
which is the same as the assembly for `object`. NETCORE 3.1 has it in
`System.Diagnostics.Tools.dll`. However MS might decide to move it around in
net7+. That assemblies list might have duplicates, `CSharpCompilation` takes
care of that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 745223)
Time Spent: 4h 50m (was: 4h 40m)
> C# Avrogen Add Generated Code Attribute
> ---------------------------------------
>
> Key: AVRO-3453
> URL: https://issues.apache.org/jira/browse/AVRO-3453
> Project: Apache Avro
> Issue Type: Improvement
> Components: csharp
> Affects Versions: 1.11.1
> Reporter: Kyle Schoonover
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 4h 50m
> Remaining Estimate: 0h
>
> Development environments that use Code Analysis or something similar attempt
> to exclude auto generated code. By adding this attribute to generated
> classes, code analysis will skip over evaluating the code.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
