[
https://issues.apache.org/jira/browse/AVRO-3453?focusedWorklogId=745226&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-745226
]
ASF GitHub Bot logged work on AVRO-3453:
----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Mar/22 16:36
Start Date: 21/Mar/22 16:36
Worklog Time Spent: 10m
Work Description: zcsizmadia commented on a change in pull request #1605:
URL: https://github.com/apache/avro/pull/1605#discussion_r831312042
##########
File path: lang/csharp/src/apache/test/AvroGen/AvroGenHelper.cs
##########
@@ -97,16 +97,20 @@ public static Assembly
CompileCSharpFilesIntoLibrary(IEnumerable<string> sourceF
Path.Combine(assemblyPath, "netstandard.dll")
};
+#if NETCOREAPP3_1
Review comment:
btw I am adding protocol tests for avrogen in a new PR, and I reuse the
piece of code you change. But I wiull take care of themergeconflicts if they
occur. Are you planning to add an attribute exists check in the loop which
iterates through all the types right after the compilation? In that case you
need additional tests or use cases, every type compiled by the unit test must
have the attribute.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 745226)
Time Spent: 5h (was: 4h 50m)
> C# Avrogen Add Generated Code Attribute
> ---------------------------------------
>
> Key: AVRO-3453
> URL: https://issues.apache.org/jira/browse/AVRO-3453
> Project: Apache Avro
> Issue Type: Improvement
> Components: csharp
> Affects Versions: 1.11.1
> Reporter: Kyle Schoonover
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 5h
> Remaining Estimate: 0h
>
> Development environments that use Code Analysis or something similar attempt
> to exclude auto generated code. By adding this attribute to generated
> classes, code analysis will skip over evaluating the code.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
