[
https://issues.apache.org/jira/browse/AVRO-3540?focusedWorklogId=787489&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-787489
]
ASF GitHub Bot logged work on AVRO-3540:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Jul/22 05:44
Start Date: 04/Jul/22 05:44
Worklog Time Spent: 10m
Work Description: czf commented on code in PR #1728:
URL: https://github.com/apache/avro/pull/1728#discussion_r912643200
##########
lang/csharp/src/apache/main/Reflect/ClassCache.cs:
##########
@@ -249,33 +249,19 @@ public void LoadClassCache(Type objType, Schema s)
LoadClassCache(objType.GenericTypeArguments[0],
ars.ItemSchema);
break;
case MapSchema ms:
- if (!objType.IsGenericType &&
!typeof(IDictionary).IsAssignableFrom(objType))
- {
- throw new AvroException($"Cant map type {objType.Name}
to map {ms.Name}");
- }
-
- if (!objType.IsGenericType)
- {
- throw new AvroException($"Cant map non-generic type
{objType.Name} to map {ms.Name}");
+ var dictionaryType =
FindOpenGenericInterface(typeof(IDictionary<,>), objType);
+ if (dictionaryType == null)
+ {
+ throw new AvroException($"Can't map type
{objType.Name} to map {ms.Name}");
Review Comment:
Yeah I wasn't trying to change too much behavior for this. Wanted to keep
the same exception
Issue Time Tracking
-------------------
Worklog Id: (was: 787489)
Time Spent: 3h (was: 2h 50m)
> .NET/C# Allow Reflect reader/writer to support Dictionaries keyed by
> something other than string
> ------------------------------------------------------------------------------------------------
>
> Key: AVRO-3540
> URL: https://issues.apache.org/jira/browse/AVRO-3540
> Project: Apache Avro
> Issue Type: Improvement
> Components: csharp
> Reporter: Christopher Fingar
> Priority: Major
> Labels: pull-request-available
> Time Spent: 3h
> Remaining Estimate: 0h
>
> Currently the existing reflect code does not support converting other key
> types to string.
> My change provides an opt-in functionality using the default converters.
> This allows users to keep there existing code instead of converting types to
> use string keys.
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
