[
https://issues.apache.org/jira/browse/AVRO-3540?focusedWorklogId=794536&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-794536
]
ASF GitHub Bot logged work on AVRO-3540:
----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Jul/22 17:39
Start Date: 23/Jul/22 17:39
Worklog Time Spent: 10m
Work Description: czf commented on code in PR #1728:
URL: https://github.com/apache/avro/pull/1728#discussion_r928147578
##########
lang/csharp/src/apache/main/Reflect/ClassCache.cs:
##########
@@ -290,5 +304,26 @@
break;
}
}
+ private static Type FindOpenGenericInterface(
+ Type expected,
+ Type actual)
+ {
+ if (actual.IsGenericType &&
+ actual.GetGenericTypeDefinition() == expected)
+ {
+ return actual;
+ }
+
+ Type[] interfaces = actual.GetInterfaces();
+ foreach (Type interfaceType in interfaces)
+ {
+ if (interfaceType.IsGenericType &&
+ interfaceType.GetGenericTypeDefinition() == expected)
+ {
+ return interfaceType;
+ }
+ }
Review Comment:
refactored to use FirstOrDefault
##########
lang/csharp/src/apache/main/Reflect/DotnetProperty.cs:
##########
@@ -136,5 +142,27 @@
_property.SetValue(o, v);
}
}
+
+ private static Type FindOpenGenericInterface(
+ Type expected,
+ Type actual)
+ {
+ if (actual.IsGenericType &&
+ actual.GetGenericTypeDefinition() == expected)
+ {
+ return actual;
+ }
+
+ Type[] interfaces = actual.GetInterfaces();
+ foreach (Type interfaceType in interfaces)
+ {
+ if (interfaceType.IsGenericType &&
+ interfaceType.GetGenericTypeDefinition() == expected)
+ {
+ return interfaceType;
+ }
+ }
Review Comment:
refactored to use FirstOrDefault
##########
lang/csharp/src/apache/main/Reflect/ReflectDefaultWriter.cs:
##########
@@ -203,5 +232,26 @@
throw new AvroException("Unknown schema type: " + sc.Tag);
}
}
+ private static Type FindOpenGenericInterface(
+ Type expected,
+ Type actual)
+ {
+ if (actual.IsGenericType &&
+ actual.GetGenericTypeDefinition() == expected)
+ {
+ return actual;
+ }
+
+ Type[] interfaces = actual.GetInterfaces();
+ foreach (Type interfaceType in interfaces)
+ {
+ if (interfaceType.IsGenericType &&
+ interfaceType.GetGenericTypeDefinition() == expected)
+ {
+ return interfaceType;
+ }
+ }
Review Comment:
refactored to use FirstOrDefault
Issue Time Tracking
-------------------
Worklog Id: (was: 794536)
Time Spent: 3h 40m (was: 3.5h)
> .NET/C# Allow Reflect reader/writer to support Dictionaries keyed by
> something other than string
> ------------------------------------------------------------------------------------------------
>
> Key: AVRO-3540
> URL: https://issues.apache.org/jira/browse/AVRO-3540
> Project: Apache Avro
> Issue Type: Improvement
> Components: csharp
> Reporter: Christopher Fingar
> Priority: Major
> Labels: pull-request-available
> Attachments: AVRO-3540.patch
>
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
> Currently the existing reflect code does not support converting other key
> types to string.
> My change provides an opt-in functionality using the default converters.
> This allows users to keep there existing code instead of converting types to
> use string keys.
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
