[
https://issues.apache.org/jira/browse/AVRO-3540?focusedWorklogId=794535&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-794535
]
ASF GitHub Bot logged work on AVRO-3540:
----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Jul/22 17:38
Start Date: 23/Jul/22 17:38
Worklog Time Spent: 10m
Work Description: czf commented on code in PR #1728:
URL: https://github.com/apache/avro/pull/1728#discussion_r928147525
##########
lang/csharp/src/apache/test/Reflect/TestReflect.cs:
##########
@@ -21,12 +21,172 @@
using NUnit.Framework;
using Avro.IO;
using Avro.Reflect;
+using System.Collections.Generic;
+using System;
+using Avro.Specific;
+using System.Linq;
+using System.Diagnostics.CodeAnalysis;
namespace Avro.Test
{
[TestFixture]
class TestReflect
{
+ public class IDictionaryTestClass : IDictionary<string, int>
+ {
+ Dictionary<string, int> _pairs = new Dictionary<string, int>();
Review Comment:
set to readonly
Issue Time Tracking
-------------------
Worklog Id: (was: 794535)
Time Spent: 3.5h (was: 3h 20m)
> .NET/C# Allow Reflect reader/writer to support Dictionaries keyed by
> something other than string
> ------------------------------------------------------------------------------------------------
>
> Key: AVRO-3540
> URL: https://issues.apache.org/jira/browse/AVRO-3540
> Project: Apache Avro
> Issue Type: Improvement
> Components: csharp
> Reporter: Christopher Fingar
> Priority: Major
> Labels: pull-request-available
> Attachments: AVRO-3540.patch
>
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> Currently the existing reflect code does not support converting other key
> types to string.
> My change provides an opt-in functionality using the default converters.
> This allows users to keep there existing code instead of converting types to
> use string keys.
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
