That's great news. Thank you! D.
On Tue, Oct 16, 2018 at 6:06 PM Thomas Weise <[email protected]> wrote: > Congrats to the Euphoria team! > > On Tue, Oct 16, 2018 at 8:51 AM Kenneth Knowles <[email protected]> wrote: > >> Merged. Welcome to the repo :-) >> >> Kenn >> >> On Thu, Oct 11, 2018 at 10:06 AM Kenneth Knowles <[email protected]> wrote: >> >>> I've filed the IP Clearance. I'll report back here. >>> >>> Kenn >>> >>> On Wed, Oct 10, 2018 at 3:33 PM David Morávek <[email protected]> >>> wrote: >>> >>>> >>>> >>>> Anton: >>>> All of the points are be correct, with one minor exception. We are >>>> currently moving our production workloads from Euphoria >>>> <https://github.com/seznam/euphoria> to Beam (using the DSL), but we >>>> are hitting scalability issues of the current spark runner, so it is not >>>> technically used in production yet. Everything behaves correctly in the >>>> staging environment, where runner can handle the workload. >>>> >>>> Kenn: >>>> here is the the IP Clearance document >>>> https://gist.github.com/dmvk/80acb0579f196e18c02a4e280978d445 >>>> >>>> Thanks, >>>> David >>>> >>>> On Wed, Oct 10, 2018 at 11:30 PM Kenneth Knowles <[email protected]> >>>> wrote: >>>> >>>>> I just glanced through it to make sure things are in the right place >>>>> and build set up right and that all LGTM. >>>>> >>>>> We need to file the IP Clearance to finish the process that Davor >>>>> started. Please fill the XML template at >>>>> http://svn.apache.org/repos/asf/incubator/public/trunk/content/ip-clearance/ip-clearance-template.xml >>>>> then I will review and file it in SVN. >>>>> >>>>> Kenn >>>>> >>>>> On Wed, Oct 10, 2018 at 2:15 PM Anton Kedin <[email protected]> wrote: >>>>> >>>>>> I think the code looks good and we should probably just merge it >>>>>> (unless there are other blockers, e.g. formal approvals), considering: >>>>>> - it has been reviewed; >>>>>> - it is tested and used in production; >>>>>> - it was discussed on the list and there were no objections to >>>>>> having it as part of Beam; >>>>>> - it is a standalone extension and doesn't interfere with Beam Java >>>>>> SDK, if I didn't miss anything; >>>>>> - it has people working on it and supporting it; >>>>>> >>>>>> All other issues can probably be sorted out in normal Beam process. >>>>>> >>>>>> Regards, >>>>>> Anton >>>>>> >>>>>> On Wed, Oct 10, 2018 at 5:57 AM David Morávek < >>>>>> [email protected]> wrote: >>>>>> >>>>>>> Hello Max, >>>>>>> >>>>>>> It would be great if you can do more of a "general" review, the code >>>>>>> base is fairly large, well tested and it was already reviewed >>>>>>> internally by >>>>>>> several people. >>>>>>> >>>>>>> We would like to have the overall approach and design decisions >>>>>>> validated by the community and get some inputs on what could be improved >>>>>>> and if we are headed the right direction. >>>>>>> >>>>>>> Thanks, >>>>>>> David >>>>>>> >>>>>>> On Wed, Oct 10, 2018 at 2:21 PM Maximilian Michels <[email protected]> >>>>>>> wrote: >>>>>>> >>>>>>>> That is a huge PR! :) Euphoria looks great. Especially for people >>>>>>>> coming >>>>>>>> from Flink/Spark. I'll check out the documentation. >>>>>>>> >>>>>>>> Do you have any specific code parts which you want to have reviewed? >>>>>>>> >>>>>>>> Thanks, >>>>>>>> Max >>>>>>>> >>>>>>>> On 10.10.18 10:30, Jean-Baptiste Onofré wrote: >>>>>>>> > Hi, >>>>>>>> > >>>>>>>> > Thanks for all the work you are doing on this DSL ! >>>>>>>> > >>>>>>>> > I tried to follow the features branch for a while. I'm still >>>>>>>> committed >>>>>>>> > to move forward on that front, but more reviewers would be >>>>>>>> great. >>>>>>>> > >>>>>>>> > Regards >>>>>>>> > JB >>>>>>>> > >>>>>>>> > On 10/10/2018 10:26, Plajt, Vaclav wrote: >>>>>>>> >> Hello Beam devs, >>>>>>>> >> we finished our main goals in development of Euphoria DSL. It is >>>>>>>> Easy to >>>>>>>> >> use Java 8 API build on top of the Beam's Java SDK. API provides >>>>>>>> a >>>>>>>> >> high-level abstraction of data transformations, with focus on >>>>>>>> the Java 8 >>>>>>>> >> language features (e.g. lambdas and streams). It is fully >>>>>>>> inter-operable >>>>>>>> >> with existing Beam SDK and convertible back and forth. It allows >>>>>>>> fast >>>>>>>> >> prototyping through use of (optional) Kryo based coders and can >>>>>>>> be >>>>>>>> >> seamlessly integrated into existing Beam Pipelines. >>>>>>>> >> >>>>>>>> >> Now we believe that it is the time to start discussion about it >>>>>>>> with the >>>>>>>> >> community. Which will hopefully lead to vote about adapting it >>>>>>>> into >>>>>>>> >> Apache Beam project. Most of main ideas and development goals >>>>>>>> were >>>>>>>> >> presented in Beam Summit in London [1]. >>>>>>>> >> >>>>>>>> >> We are looking for reviewers within the community. Please start >>>>>>>> with >>>>>>>> >> documentation [2] or design document [3]. Our contribution is >>>>>>>> divided to >>>>>>>> >> two modules: >>>>>>>> `org.apache.beam:beam-sdks-java-extensions-euphoria` and >>>>>>>> >> `org.apache.beam:beam-sdks-java-extensions-kryo`. Rest of the >>>>>>>> code base >>>>>>>> >> remains untouched. >>>>>>>> >> All the checks in MR [5] are passing with exception of "Website >>>>>>>> >> PreCommit". Which seems to be broken, little help here would be >>>>>>>> appreciated. >>>>>>>> >> >>>>>>>> >> Thank you >>>>>>>> >> We are looking forward for your feedback. >>>>>>>> >> {david.moravek,vaclav.plajt,marek.simunek}@firma.seznam.cz >>>>>>>> >> >>>>>>>> >> Resources: >>>>>>>> >> [1] Beam Summit London presentation: >>>>>>>> >> >>>>>>>> https://docs.google.com/presentation/d/1SagpmzJ-tUQki5VsQOEEEUyi_LXRJdG_3OBLdjBKoh4/edit?usp=sharing >>>>>>>> >> [2] Documentation: >>>>>>>> >> >>>>>>>> https://github.com/seznam/beam/blob/dsl-euphoria/website/src/documentation/sdks/euphoria.md >>>>>>>> >> [3] Design Document: https://s.apache.org/beam-euphoria >>>>>>>> >> [4] ASF Jira Issue: >>>>>>>> https://issues.apache.org/jira/browse/BEAM-3900 >>>>>>>> >> [5] Pull Request: https://github.com/apache/beam/pull/6601 >>>>>>>> >> [6] Original proposal: >>>>>>>> >> >>>>>>>> http://mail-archives.apache.org/mod_mbox/beam-dev/201712.mbox/%3ccajjqkhnrp1z8atteogmpfkqxrcjeanb3ykowvvtnwyrvv_-...@mail.gmail.com%3e >>>>>>>> >> >>>>>>>> >> >>>>>>>> >> >>>>>>>> >> Je dobré vědět, že tento e-mail a přílohy jsou důvěrné. Pokud >>>>>>>> spolu >>>>>>>> >> jednáme o uzavření obchodu, vyhrazujeme si právo naše jednání >>>>>>>> kdykoli >>>>>>>> >> ukončit. Pro fanoušky právní mluvy - vylučujeme tím ustanovení >>>>>>>> >> občanského zákoníku o předsmluvní odpovědnosti. Pravidla o tom, >>>>>>>> kdo u >>>>>>>> >> nás a jak vystupuje za společnost a kdo může co a jak podepsat >>>>>>>> naleznete >>>>>>>> >> zde <https://onas.seznam.cz/cz/podpisovy-rad-cz.html> >>>>>>>> >> >>>>>>>> >> You should know that this e-mail and its attachments are >>>>>>>> confidential. >>>>>>>> >> If we are negotiating on the conclusion of a transaction, we >>>>>>>> reserve the >>>>>>>> >> right to terminate the negotiations at any time. For fans of >>>>>>>> legalese—we >>>>>>>> >> hereby exclude the provisions of the Civil Code on >>>>>>>> pre-contractual >>>>>>>> >> liability. The rules about who and how may act for the company >>>>>>>> and what >>>>>>>> >> are the signing procedures can be found here >>>>>>>> >> <https://onas.seznam.cz/cz/signature-rules.html>. >>>>>>>> > >>>>>>>> >>>>>>>
