On Fri, Nov 16, 2018 at 8:25 PM Ahmet Altay <al...@google.com> wrote:
> > > On Fri, Nov 16, 2018 at 8:16 PM, Thomas Weise <t...@apache.org> wrote: > >> >> >> On Fri, Nov 16, 2018 at 8:02 PM Ahmet Altay <al...@google.com> wrote: >> >>> >>> >>> On Fri, Nov 16, 2018 at 6:25 PM, Thomas Weise <t...@apache.org> wrote: >>> >>>> >>>> >>>> On Thu, Nov 15, 2018 at 10:53 PM Charles Chen <c...@google.com> wrote: >>>> >>>>> +1 >>>>> >>>>> Note that we need to temporarily revert >>>>> https://github.com/apache/beam/pull/6683 before the release branch >>>>> cut per the discussion at >>>>> https://lists.apache.org/thread.html/78fe33dc41b04886f5355d66d50359265bfa2985580bb70f79c53545@%3Cdev.beam.apache.org%3E >>>>> >>>>> >>>> Since it is for the release I would prefer this to be done in the >>>> release branch, and not in master. >>>> >>> >>> Do we have a plan to resolve this issue in the master? It is additional >>> work to do this while doing releases. >>> >> >> The discussion thread above has latest for this. It does not look like it >> will be resolved in time, but we also need the functionality to exist in >> master. >> >> Revert in the release branch should be less work. In master, you would >> first need to revert and then revert that revert, which would be >> unnecessary noise. >> > > Sounds good, thank you for the explanation. > According to https://issues.apache.org/jira/browse/BEAM-6085, sounds like the concern is post-commit test coverage if we just do the revert in the branch. I'll try to create a revert in master branch and trigger post-commit test suites to confirm that this doesn't break things before submitting that to the branch. If this is inadequate for some reason we might have to perform the revert in the master branch first. Please follow the JIRA for updates. Thanks, Cham > > >> >> >>> >>>> >>>> >>>> >>>> >>>> >>>>> On Thu, Nov 15, 2018 at 9:18 PM Tim <timrobertson...@gmail.com> wrote: >>>>> >>>>>> Thanks Cham >>>>>> +1 >>>>>> >>>>>> On 16 Nov 2018, at 05:30, Thomas Weise <t...@apache.org> wrote: >>>>>> >>>>>> +1 >>>>>> >>>>>> >>>>>> On Thu, Nov 15, 2018 at 4:34 PM Ahmet Altay <al...@google.com> wrote: >>>>>> >>>>>>> +1 Thank you. >>>>>>> >>>>>>> On Thu, Nov 15, 2018 at 4:22 PM, Kenneth Knowles <k...@apache.org> >>>>>>> wrote: >>>>>>> >>>>>>>> SGTM. Thanks for keeping track of the schedule. >>>>>>>> >>>>>>>> Kenn >>>>>>>> >>>>>>>> On Thu, Nov 15, 2018 at 1:59 PM Chamikara Jayalath < >>>>>>>> chamik...@google.com> wrote: >>>>>>>> >>>>>>>>> Hi All, >>>>>>>>> >>>>>>>>> According to the release calendar [1] branch cut date for Beam >>>>>>>>> 2.9.0 release is 11/21/2018. Since previous release branch was cut >>>>>>>>> close to >>>>>>>>> the respective calendar date I'd like to propose cutting release >>>>>>>>> branch for >>>>>>>>> 2.9.0 on 11/21/2018. Next week is Thanksgiving holiday in US and >>>>>>>>> possibly >>>>>>>>> some folks will be out so we can try to produce RC1 on Monday after >>>>>>>>> (11/26/2018). We can attend to current blocker JIRAs [2] in the >>>>>>>>> meantime. >>>>>>>>> >>>>>>>>> I'd like to volunteer to perform this release. >>>>>>>>> >>>>>>>>> WDYT ? >>>>>>>>> >>>>>>>>> Thanks, >>>>>>>>> Cham >>>>>>>>> >>>>>>>>> [1] >>>>>>>>> https://calendar.google.com/calendar/embed?src=0p73sl034k80oob7seouanigd0%40group.calendar.google.com&ctz=America%2FLos_Angeles >>>>>>>>> [2] https://s.apache.org/beam-2.9.0-burndown >>>>>>>>> >>>>>>>>> >>>>>>> >>> >
