[
https://issues.apache.org/jira/browse/BIGTOP-1221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13918969#comment-13918969
]
Mark Grover commented on BIGTOP-1221:
-------------------------------------
Sorry, it took me a little longer to get back but here is my feedback. Left
some feedback on reviewboard.
* Can you please update the reviewboard with the latest patch? I really prefer
reviewboard for large patches like this and it seems like you incorporated Cos'
feedback but forgot to update reviewboard.
* I tried applying the patch on master and got some whitespace related warnings:
{code}
Applying: BIGTOP-1221: Significant update FUSE tests to test more feature,
consistency, and file contents + smoke test for HDFS-6027.
/opt/src/bigtop/.git/rebase-apply/patch:43: trailing whitespace.
* This is a "superset" of the hdfs/TestFuseDFS class.
/opt/src/bigtop/.git/rebase-apply/patch:46: trailing whitespace.
* After all, FUSE is an interface, and it should be tested at that level, with
/opt/src/bigtop/.git/rebase-apply/patch:49: trailing whitespace.
*
/opt/src/bigtop/.git/rebase-apply/patch:51: trailing whitespace.
* and thus somewhat overcommented for the first iteration, we can clean
comments up
/opt/src/bigtop/.git/rebase-apply/patch:61: trailing whitespace.
warning: squelched 14 whitespace errors
warning: 19 lines add whitespace errors.
{code}
Some of them maybe from before your time, and if so, try to see if you can fix
them. If it's something you are including, see if you can fix it.
> Expand and updated FUSE tests
> -----------------------------
>
> Key: BIGTOP-1221
> URL: https://issues.apache.org/jira/browse/BIGTOP-1221
> Project: Bigtop
> Issue Type: Bug
> Components: Tests
> Affects Versions: 0.7.0
> Reporter: jay vyas
> Assignee: jay vyas
> Fix For: 0.8.0
>
> Attachments: BIGTOP-1221-cos-fixes.patch, BIGTOP-1221.patch
>
>
> The BigTop TestFuseDFS need
> - tests for consistency after individual writes : consistency in FUSE mounts
> is important since there are often associated multitenant workloads. Writes
> should result in immediate recognition of a file.
> - Should use HCFS semantics (That way we can confidently use and maintain
> this for alternative file system implementations).
> - should use logging instead of System.out. That way all the logs can be
> picked up from the same place in case we change the logging framework.
> Logging in trace mode, in any case, will allow us to see everything that the
> ITest shell does, and so might as well use it for other logs.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
