[
https://issues.apache.org/jira/browse/BIGTOP-1221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13920271#comment-13920271
]
jay vyas commented on BIGTOP-1221:
----------------------------------
okay. cos + mark.
I'll put all the comments inline here. first ill start w/ cos: next thread
ill address marks issues.
cos's comments:
- conceptually speaking: how this new test relates to the original TestFuseDFS?
Will it be a replacement to the original test? If so, the old class should be
gone as the part of the same patch
response: I've deleted that file now.
- as always - indentation is wrong
response: ive manually fixed up the indents. are they still bad?
- in the testCp (and elsewhere) you use full paths inconsistently. Is there a
reason for that?
response: This is answered above: /bin/cp is the full path your referencing,
and ive used it so as to avoid aliased cp, which can result in the overwrite
prompts. Best to be deterministic about how "cp" is called in a FUSE test IMO.
- there are some comments formatting issues that need to be addressed
response: I've manually attempted to address formating of comments. are they
still messed up?
> Expand and updated FUSE tests
> -----------------------------
>
> Key: BIGTOP-1221
> URL: https://issues.apache.org/jira/browse/BIGTOP-1221
> Project: Bigtop
> Issue Type: Bug
> Components: Tests
> Affects Versions: 0.7.0
> Reporter: jay vyas
> Assignee: jay vyas
> Fix For: 0.8.0
>
> Attachments: BIGTOP-1221-tested-refined-3.patch
>
>
> The BigTop TestFuseDFS need
> - tests for consistency after individual writes : consistency in FUSE mounts
> is important since there are often associated multitenant workloads. Writes
> should result in immediate recognition of a file.
> - Should use HCFS semantics (That way we can confidently use and maintain
> this for alternative file system implementations).
> - should use logging instead of System.out. That way all the logs can be
> picked up from the same place in case we change the logging framework.
> Logging in trace mode, in any case, will allow us to see everything that the
> ITest shell does, and so might as well use it for other logs.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
