[
https://issues.apache.org/jira/browse/BIGTOP-1221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13921535#comment-13921535
]
Mark Grover commented on BIGTOP-1221:
-------------------------------------
Hi Jay, I looked at the review. It looks like you incorporated some of my
feedback, thank you. However, it seems like you may have missed some of the
comments. In any case, I have put them up again on the latest diff: So if you
simply go to https://reviews.apache.org/r/18593/diff/#index_header, you will
see the blue bubbles on the left which symbolize comments.
It looks like a very nice re-structuring of the code, thanks for undertaking
this effort. A few things:
1. I am ok with the way you have isHDFS variable, so please feel free to keep
it that way.
2. I am ok with you renaming the test from the TestFuseDFS to TestFuseHCFS.
Let's just make sure by a quick grep nothing else in the code refers to the old
name.
3. It seemed like you were using the first argument of asserts as a message
about what the assert is doing e.g. "verifying ..." etc. However, my
understanding is that the first string argument is printed when the assertion
fails, so I'd think they should be error messages, otherwise it would be very
misleading for another person like me trying to triage a test output to figure
out what exactly was going on. Can you reword them to be error messages please?
For example, if you were asserting that the exit code was zero, a good first
string argument (i.e. error message) would be "Exit code was not zero".
> Expand and updated FUSE tests
> -----------------------------
>
> Key: BIGTOP-1221
> URL: https://issues.apache.org/jira/browse/BIGTOP-1221
> Project: Bigtop
> Issue Type: Bug
> Components: Tests
> Affects Versions: 0.7.0
> Reporter: jay vyas
> Assignee: jay vyas
> Fix For: 0.8.0
>
> Attachments: BIGTOP-1221-tested-refined-3.patch,
> BIGTOP-1221.4.intellij.patch, BIGTOP-1221.patch
>
>
> The BigTop TestFuseDFS need
> - tests for consistency after individual writes : consistency in FUSE mounts
> is important since there are often associated multitenant workloads. Writes
> should result in immediate recognition of a file.
> - Should use HCFS semantics (That way we can confidently use and maintain
> this for alternative file system implementations).
> - should use logging instead of System.out. That way all the logs can be
> picked up from the same place in case we change the logging framework.
> Logging in trace mode, in any case, will allow us to see everything that the
> ITest shell does, and so might as well use it for other logs.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
