Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/492#discussion_r92641835
--- Diff:
core/src/main/java/org/apache/brooklyn/core/mgmt/persist/DeserializingClassRenamesProvider.java
---
@@ -72,7 +81,7 @@
} finally {
Streams.closeQuietly(resource);
}
- } else {
+ } catch (Exception e) {
--- End diff --
We should at least log when there is an exception - never swallow the
exception.
Suggest we check if the resource exists (e.g. `if (resource == null)`?),
rather than relying on a `NullPointerException` from `props.load(resource)`
inside the try-catch (which I guess happens if there is no such file?).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
