Github user aledsage commented on the issue:

    https://github.com/apache/brooklyn-server/pull/492
  
    Given the class is static, I wondered about Brooklyn's startup injecting 
the karaf config via some static method call. But I prefer @neykov's suggestion 
that we get the karaf config admin via appropriate static method calls (if 
that's feasible).
    
    @neykov @tbouron colons are acceptable separators in properties files: 
https://docs.oracle.com/cd/E23095_01/Platform.93/ATGProgGuide/html/s0204propertiesfileformat01.html
    
    ---
    I wonder what we should do about 
https://github.com/apache/brooklyn-server/pull/144. It feels right that we 
support multiple files, rather than a user having to duplicate all of the 
brooklyn entries in their user-specific file (I think it's right that you've 
added the karaf file second, so it overrides the defaults).
    
    I agree with Svet that we want a bundle author to be able to supply their 
own file. Let's tackle that by re-visiting #144, rather than in this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to