Github user tbouron commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/492#discussion_r92644961
--- Diff:
core/src/main/java/org/apache/brooklyn/core/mgmt/persist/DeserializingClassRenamesProvider.java
---
@@ -72,7 +81,7 @@
} finally {
Streams.closeQuietly(resource);
}
- } else {
+ } catch (Exception e) {
--- End diff --
This one is safe. It is for the `new
ResourceUtils(DeserializingClassRenamesProvider.class).getResourceFromUrl(url);`
As per as the javadoc:
> Takes a string which is treated as a URL (with some extended "schemes"
also expected), or as a path to something either on the classpath (absolute
only) or the local filesystem (relative or absolute, depending on leading slash)
URLs can be of the form classpath://com/acme/Foo.properties as well as
file:///home/... and http://acme.com/....
**Throws exception if not found**, using the context parameter passed into
the constructor.
TODO may want OSGi, or typed object; should consider pax url
Returns:
a stream, or throws exception **(never returns null)**
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
