Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/108#issuecomment-51321797
EntityAdjuct: think I agree - I'll try refactoring and see how it feels.
Building on #106 - I'll wait for that to be merged, and then incorporate
the uniqueTag.
Serializing JmxFeed connections etc - I haven't tested with JmxFeed; just
the SshFeed, FunctionFeed and HttpFeed. I'll add a test for that.
I'll need to declare the JmxHelper transient, and figure out how to
recreate that.
I suspect the rest will work though as the underlying Poller is transient.
It should only persist the JmxAttributePollConfig etc.
Warn if feed is not attached: tricky.
Currently feedBuilder.build() will start it, and then the feed is
registered with the entity.
This means we can't check at start-time.
If we switch to an EntityAdjuct type of model, then we'll follow a
`AbstractEntityAdjunct.setEntity()` approach so that will change anyway. This
might well give us a better place to hook in the check.
Removing redundant clean-up code: agreed, but not yet sure what it should
look like.
On entity.unmanage, it can certainly automatically stop any feeds.
However, we want to stop the feeds at a particular point during the
`SoftwareProcess.stop`.
This could now be done in the super-class `SoftwareProcessImpl`.
But are there every any places where we don't want all feeds to be stopped
before stopping the actual process?
Restructuring persistence: agreed something like that will be easier to
navigate. We should discuss that `dev@brooklyn` list.
For example, should the `app/12345678/entities/...` be strictly
hierarchical (i.e. children of an entity are under that entity), or should all
entities of an app be in the same dir (which is my preference I think). Should
we separate them by app or just put all entities (including apps) at the same
level. If an app could ever start being managed with no parent and then have
its parent set we should keep them all at same level (but I don't think that's
supported, so probably not important here).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
