Hello everyone,
FYI, it seems that since the merge into master of CALCITE-4238 [1] (via
[2]), AppVeyor tests are failing systematically with the following error
[3]:
[00:03:17] Build calcite FAILURE reason:
[00:03:17] Execution failed for task ':core:fmppMain':
[00:03:17] : Failed to initialize FMPP engine.
[00:03:17] Caused by: Failed to apply the value of the "data"
setting.
[00:03:17]
[00:03:17] Caused by:
[00:03:17] TDD syntax error: The + operator ("hash union") is
deprecated since FMPP 0.9.0, and starting from FMPP 0.9.9 it is not allowed
at all. Please use "hash addition" instead. For example, assuming that your
configuration file is in .properties format (same as .cfg), instead of this:
[00:03:17] data={a:1, b:2} + properties(data/style.properties) +
birds:csv(data/birds.csv)
[00:03:17] your should write this:
[00:03:17] data=a:1, b:2, tdd(data/style.tdd),
birds:csv(data/birds.csv)
[00:03:17] For more information on hash addition please see:
[00:03:17] http://fmpp.sourceforge.net/tdd.html#hashAddition
[00:03:17] Error location: line 1, column 25:
[00:03:17] tdd(C:\projects\calcite +\core\src\main\codegen\confi...
[00:03:17] ^
[00:03:17] at fmpp.tools.AntTask.execute(AntTask.java:608)
The error does not occur with other CI environments. I have the impression
it might be related to FmppTask.kt [4].
I am not sure if this is a major issue that could jeopardize the release or
not (since it only appears on AppVeyor).
So far I have not been able to reproduce it in my local environment. I will
continue trying.
If someone with a bit more experience on FMPP / Kotlin could take a look, I
would appreciate it.
Best Regards,
Ruben
[1] https://issues.apache.org/jira/browse/CALCITE-4238
[2]
https://github.com/apache/calcite/commit/0b2dfb70dd9a97495283388a9edcbe2b12ddfec3
[3]
https://ci.appveyor.com/project/ApacheSoftwareFoundation/calcite/builds/35487356/job/t3mbcy7tk9o8o5a8#L110
[4]
https://github.com/apache/calcite/blob/539807bb0558890c2a92d0fc2af20c741a775fbc/buildSrc/subprojects/fmpp/src/main/kotlin/org/apache/calcite/buildtools/fmpp/FmppTask.kt#L66
On Wed, Sep 30, 2020 at 3:26 AM Danny Chan <[email protected]> wrote:
> The schedule sounds good to me, thanks Ruben for being the release manager
> ~
>
> Best,
> Danny Chan
> 在 2020年9月30日 +0800 AM3:44，Julian Hyde <[email protected]>，写道：
> > > What is the status on 4279 (SEARCH operator into Druid)?
> >
> > Working on it.
> >
> > > On Sep 29, 2020, at 11:58 AM, Ruben Q L <[email protected]> wrote:
> > >
> > > Thanks for the feedback, Julian.
> > > I will keep in mind changing 'MacOS' to 'macOS' in the release notes.
> > > What is the status on 4279 (SEARCH operator into Druid)?
> > >
> > > Ruben
> > >
> > >
> > >
> > > Le mar. 29 sept. 2020 à 19:51, Julian Hyde <[email protected]> a
> > > écrit :
> > >
> > > > Thursday sounds good.
> > > >
> > > > I am working on getting 3752 (PIVOT) and 4238 (parser configuration)
> > > > passing CI and merged. (4238 changes buildSrc and that seems to
> freak out
> > > > Gradle’s cache in CI.)
> > > >
> > > > For 4034 (InnoDB adapter), I am waiting for Xu (neoremind) to fix a
> > > > remaining bug. Don’t hold the release for 4034.
> > > >
> > > > As RM, can you please change ‘MacOS’ to ‘macOS’ (2 occurrences) when
> you
> > > > write the release notes. It got changed by accident last release.
> > > >
> > > > Julian
> > > >
> > > >
> > > > > On Sep 29, 2020, at 12:36 AM, Ruben Q L <[email protected]> wrote:
> > > > >
> > > > > Hello,
> > > > >
> > > > > things are moving forward, thanks everyone for pushing the pending
> issues
> > > > > into the release.
> > > > > There are still a few unresolved tickets [1], but most of them
> have a PR
> > > > > available and in good shape, so I think we can be reasonably
> optimistic.
> > > > > Would it sound feasible to get these final tickets resolved in the
> next
> > > > > couple of days and enter code freeze for master e.g. on Thursday
> night in
> > > > > order to have a first RC during the weekend?
> > > > >
> > > > > Best,
> > > > > Ruben
> > > > >
> > > > > [1]
> > > > >
> > > >
> https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12333950
> > > > >
> > > > >
> > > > > Le ven. 25 sept. 2020 à 06:47, Chunwei Lei <[email protected]>
> a
> > > > > écrit :
> > > > >
> > > > > > Thank you for driving this, Ruben.
> > > > > >
> > > > > > The schedule looks good to me.
> > > > > >
> > > > > > Best,
> > > > > > Chunwei
> > > > > >
> > > > > >
> > > > > > On Thu, Sep 24, 2020 at 3:26 AM Rui Wang <[email protected]>
> wrote:
> > > > > >
> > > > > > > Thanks for all your help! Will experiment how it works best
> for me!
> > > > > > >
> > > > > > >
> > > > > > > -Rui
> > > > > > >
> > > > > > > On Wed, Sep 23, 2020 at 12:06 PM Ruben Q L <[email protected]>
> wrote:
> > > > > > >
> > > > > > > > Rui,
> > > > > > > > I am not a git expert, but what I usually do in these cases
> is
> > > > (working
> > > > > > > in
> > > > > > > > my local feature branch):
> > > > > > > > git rebase -i master
> > > > > > > > (editor will be opened, "pick" first commit, "squash" the
> rest; then
> > > > > > edit
> > > > > > > > your final squashed commit message)
> > > > > > > > Then you can force push. In your PR it should appear 1
> commit instead
> > > > > > of
> > > > > > > N.
> > > > > > > > This is just one way to do it, if you search online, you'll
> probably
> > > > > > find
> > > > > > > > better explanations than mine for this "git squash commits"
> operation.
> > > > > > > >
> > > > > > > > Best regards,
> > > > > > > > Ruben
> > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > > > Le mer. 23 sept. 2020 à 19:50, Julian Hyde <[email protected]>
> a écrit
> > > > > > :
> > > > > > > >
> > > > > > > > > Feel free to experiment. If it creates a bad result - e.g.
> a merge
> > > > > > > > > commit, or does not squash - quickly back it out with a
> force push to
> > > > > > > > > master.
> > > > > > > > >
> > > > > > > > > Maybe I'm a git dinosaur, but I always use the command
> line to merge
> > > > > > > > > my own and others' changes. I don't trust the github UI to
> do exactly
> > > > > > > > > what I want.
> > > > > > > > >
> > > > > > > > > On Wed, Sep 23, 2020 at 11:45 AM Rui Wang <
> [email protected]>
> > > > > > > wrote:
> > > > > > > > > >
> > > > > > > > > > Thanks Ruben for kicking off 1.26.0 release!
> > > > > > > > > >
> > > > > > > > > > Can I ask a question here: how can I squash commits to
> merge
> > > > > > > > > > https://github.com/apache/calcite/pull/2160? I am
> worried that if
> > > > > > I
> > > > > > > > > click
> > > > > > > > > > the "rebase and merge", it will push two commits into
> the Calcite
> > > > > > > main
> > > > > > > > > > branch.
> > > > > > > > > >
> > > > > > > > > >
> > > > > > > > > > -Rui
> > > > > > > > > >
> > > > > > > > > > On Wed, Sep 23, 2020 at 11:38 AM Ruben Q L <
> [email protected]>
> > > > > > > wrote:
> > > > > > > > > >
> > > > > > > > > > > Hi all,
> > > > > > > > > > >
> > > > > > > > > > > It has been around one and a half months since our
> last release
> > > > > > > > > (1.25.0),
> > > > > > > > > > > and it seems a good moment to start discussing our
> next one
> > > > > > 1.26.0.
> > > > > > > > > > >
> > > > > > > > > > > As we can see in our Jira dashboard [1] there are a few
> > > > > > unresolved
> > > > > > > > > issues
> > > > > > > > > > > for 1.26.
> > > > > > > > > > > However, we have 180+ open pull requests [2], some of
> them seem
> > > > > > in
> > > > > > > > good
> > > > > > > > > > > shape, even though their corresponding Jira tickets do
> not
> > > > > > specify
> > > > > > > > > 1.26 as
> > > > > > > > > > > "fix version", so they do not appear in the Jira
> dashboard. I
> > > > > > > > encourage
> > > > > > > > > > > contributors to take a look at these open issues, in
> order to
> > > > > > > confirm
> > > > > > > > > what
> > > > > > > > > > > can / should be included in the next release.
> > > > > > > > > > >
> > > > > > > > > > > Ideally, I would like to generate a RC by the end of
> next week.
> > > > > > > > > > >
> > > > > > > > > > > Do not hesitate to reply to this thread if the plan
> above is not
> > > > > > > > > > > convenient for you.
> > > > > > > > > > >
> > > > > > > > > > > Best regards,
> > > > > > > > > > > Ruben
> > > > > > > > > > >
> > > > > > > > > > > [1]
> > > > > > > > > > >
> > > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > >
> > > >
> https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12333950
> > > > > > > > > > > [2] https://github.com/apache/calcite/pulls
> > > > > > > > > > >
> > > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > >
> > > >
> > > >
> >
>
