Hi Ruben, If I remember well, you should commit them under CALCITE-4291 and then proceed with the release.
Best, Stamatis On Fri, Oct 2, 2020 at 11:06 AM Ruben Q L <[email protected]> wrote: > Hello, > > thanks everyone for your effort pushing the remaining issues forward. > We enter a code freeze in order to generate a RC0 for 1.26.0, so please DO > NOT commit into master until further notice. > > To our expert release managers, I have a stupid question about "how-to > making a release candidate" instructions [1]: > The changes that I need to "check" and "add" (README, > site/_docs/history.md, site/_docs/howto.md), do I need to commit those > changes myself before starting the RC0 generation process; or I just need > to make those changes locally, leave them uncommitted, because they will > get automatically committed during the RC generation (or publication) > process? > > Best regards, > Ruben > > [1] https://calcite.apache.org/docs/howto.html#making-a-release-candidate > > > On Thu, Oct 1, 2020 at 8:04 AM Ruben Q L <[email protected]> wrote: > > > FYI, AppVeyor issue has been resolved. > > Thanks Julian and Vladimir for your help! > > > > On Wed, Sep 30, 2020 at 7:32 PM Julian Hyde <[email protected]> > > wrote: > > > >> > >> > >> > PS. I wonder what everybody think of > >> > https://github.com/apache/calcite/pull/2182 (enable error-prone > >> > verifications) > >> > >> I’m in favor it, but since it’s a large change (and therefore potential > >> for merge conflicts), timing will be important. Early in 1.27 is > probably > >> the best timing. > >> > >> Julian > >> > >> >
