Great addition! +1 (nb)
On 2023/06/23 13:37:02 Josh McKenzie wrote: > +1 here on inclusion by default. > > On Fri, Jun 23, 2023, at 2:01 AM, Dinesh Joshi wrote: > > This would be a good addition and would make Cassandra more performant out > > of the box. > > > > Dinesh > > > >> On Jun 22, 2023, at 9:45 PM, Jordan West <jorda...@gmail.com> wrote: > >> > >> Glad to see there is support for this! I think ACCP would be a good choice > >> since there seems to be a lot of experience deploying it. I’ve opened > >> https://issues.apache.org/jira/browse/CASSANDRA-18624. I should have some > >> time to work on the patch soon and I will try to provide some graphs that > >> show the performance benefit from a recent benchmark. > >> > >> Jordan > >> > >> > >> On Thu, Jun 22, 2023 at 19:28 Fleming, Jackson > >> <jackson.flem...@netapp.com> wrote: > >>> We run ACCP in production on 1000s of nodes across Cassandra 3.11 and 4 > >>> with great results.____ > >>> __ __ > >>> Would love to see it baked into Cassandra.____ > >>> *__ __* > >>> Jackson____ > >>> __ __ > >>> *From: *David Capwell <dcapw...@apple.com> > >>> *Date: *Friday, 23 June 2023 at 9:22 am > >>> *To: *dev <dev@cassandra.apache.org> > >>> *Subject: *Re: [DISCUSS] Using ACCP or tc-native by default____ > >>> *NetApp Security WARNING*: This is an external email. Do not click links > >>> or open attachments unless you recognize the sender and know the content > >>> is safe.____ > >>> > >>> ____ > >>> +1 to ACCP____ > >>> > >>> ____ > >>>> On Jun 22, 2023, at 3:05 PM, C. Scott Andreas <sc...@paradoxica.net> > >>>> wrote:____ > >>>> __ __ > >>>> +1 for ACCP and can attest to its results. ACCP also optimizes for a > >>>> range of hash functions and other cryptographic primitives beyond TLS > >>>> acceleration for Netty.____ > >>>> __ __ > >>>>> On Jun 22, 2023, at 2:07 PM, Jeff Jirsa <jji...@gmail.com> wrote:____ > >>>>> __ __ > >>>>> __ __ > >>>>> Either would be better than today. ____ > >>>>> __ __ > >>>>> On Thu, Jun 22, 2023 at 1:57 PM Jordan West <jw...@apache.org> > >>>>> wrote:____ > >>>>>> Hi,____ > >>>>>> __ __ > >>>>>> I’m wondering if there is appetite to change the default SSL provider > >>>>>> for Cassandra going forward to either ACCP [1] or tc-native in Netty? > >>>>>> Our deployment as well as others I’m aware of make this change in > >>>>>> their fork and it can lead to significant performance improvement. > >>>>>> When recently qualifying 4.1 without using ACCP (by accident) we > >>>>>> noticed p99 latencies were 2x higher than 3.0 w/ ACCP. Wiring up ACCP > >>>>>> can be a bit of a pain and also requires some amount of customization. > >>>>>> I think it could be great for the wider community to adopt it. ____ > >>>>>> __ __ > >>>>>> The biggest hurdle I foresee is licensing but ACCP is Apache 2.0 > >>>>>> licensed. Anything else I am missing before opening a JIRA and > >>>>>> submitting a patch?____ > >>>>>> __ __ > >>>>>> Jordan ____ > >>>>>> __ __ > >>>>>> __ __ > >>>>>> [1] ____ > >>>>>> https://github.com/corretto/amazon-corretto-crypto-provider____ > >>>> __ __ > >>> __ __