Oipo commented on a change in pull request #181: Updated ZMQ implementation to
use NULL if scope is not set. Only when…
URL: https://github.com/apache/celix/pull/181#discussion_r400774220
##########
File path: bundles/pubsub/pubsub_spi/src/pubsub_utils.c
##########
@@ -92,7 +78,7 @@ celix_status_t pubsub_getPubSubInfoFromFilter(const char*
filterstr, char **topi
char* pubsub_getKeysBundleDir(celix_bundle_context_t *ctx) {
array_list_pt bundles = NULL;
bundleContext_getBundles(ctx, &bundles);
- int nrOfBundles = arrayList_size(bundles);
+ uint32_t nrOfBundles = arrayList_size(bundles);
Review comment:
arrayList_size() is deprecated, celix_arrayList_size() is preferable.
celix_arrayList_size() returns an int, even though list->size is of type
size_t. No good option here other than modifying API, IMHO
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
