abroekhuis commented on a change in pull request #181: Updated ZMQ
implementation to use NULL if scope is not set. Only when…
URL: https://github.com/apache/celix/pull/181#discussion_r400930375
##########
File path: bundles/pubsub/pubsub_discovery/src/pubsub_discovery_impl.c
##########
@@ -414,7 +414,7 @@ celix_status_t pubsub_discovery_announceEndpoint(void
*handle, const celix_prope
clock_gettime(CLOCK_MONOTONIC, &entry->createTime);
entry->isSet = false;
entry->properties = celix_properties_copy(endpoint);
- asprintf(&entry->key, "/pubsub/%s/%s/%s/%s", config, scope, topic,
uuid);
+ asprintf(&entry->key, "/pubsub/%s/%s/%s/%s", config, scope == NULL ?
"default" : scope, topic, uuid);
Review comment:
Agreed, fixed where needed. Moved the constant to pubsub_constants.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
