Oipo commented on a change in pull request #181: Updated ZMQ implementation to
use NULL if scope is not set. Only when…
URL: https://github.com/apache/celix/pull/181#discussion_r401443535
##########
File path: bundles/pubsub/pubsub_admin_zmq/src/pubsub_zmq_admin.c
##########
@@ -685,9 +658,12 @@ celix_status_t pubsub_zmqAdmin_addDiscoveredEndpoint(void
*handle, const celix_p
if (pubsub_zmqAdmin_endpointIsPublisher(endpoint)) {
celixThreadMutex_lock(&psa->topicReceivers.mutex);
- hash_map_iterator_t iter =
hashMapIterator_construct(psa->topicReceivers.map);
- while (hashMapIterator_hasNext(&iter)) {
- pubsub_zmq_topic_receiver_t *receiver =
hashMapIterator_nextValue(&iter);
+ const char *scope = celix_properties_get(endpoint,
PUBSUB_ENDPOINT_TOPIC_SCOPE, NULL);
+ const char *topic = celix_properties_get(endpoint,
PUBSUB_ENDPOINT_TOPIC_NAME, NULL);
+ char *key = pubsubEndpoint_createScopeTopicKey(scope, topic);
Review comment:
Missing free for key
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
