Oipo commented on a change in pull request #181: Updated ZMQ implementation to
use NULL if scope is not set. Only when…
URL: https://github.com/apache/celix/pull/181#discussion_r401447695
##########
File path: bundles/pubsub/pubsub_spi/src/pubsub_endpoint.c
##########
@@ -194,7 +196,11 @@ bool pubsubEndpoint_equals(const celix_properties_t
*psEp1, const celix_properti
char* pubsubEndpoint_createScopeTopicKey(const char* scope, const char* topic)
{
char *result = NULL;
- asprintf(&result, "%s:%s", scope, topic);
+ if (scope != NULL) {
+ asprintf(&result, "%s:%s", scope, topic);
+ } else {
+ asprintf(&result, "default:%s", topic);
Review comment:
Think you missed this one ;)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
