pnoltes commented on PR #470: URL: https://github.com/apache/celix/pull/470#issuecomment-1804253059
> Here are some remarks on properties implementation, and I have finished the first round review, which takes much longer than expected. That is understandable: for such a change of fundamental type used everywhere, we need to be extra careful to avoid introducing bugs. I tried my best. > > Overall, it's a nice work which brings about huge performance and ergonomics improvements. Looking forward to getting it merged and implementing #674 thereafter. Thanks for the thorough review :smile: . I will update the implementation based on the review comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@celix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
