pnoltes commented on code in PR #470:
URL: https://github.com/apache/celix/pull/470#discussion_r1389333404
##########
libs/utils/include/celix/Properties.h:
##########
@@ -145,20 +172,19 @@ namespace celix {
};
- Properties() : cProps{celix_properties_create(),
[](celix_properties_t* p) { celix_properties_destroy(p); }} {}
+ Properties() : cProps{createCProps(celix_properties_create())} {}
Properties(Properties&&) = default;
Review Comment:
Yes, I think cProps will then be nullptr.. but as for as I know a variable
to a moved object should not be used, expect to potentially reassign a new
object. or reinitialized the object.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@celix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
