pnoltes commented on code in PR #470:
URL: https://github.com/apache/celix/pull/470#discussion_r1389228884
##########
libs/utils/gtest/src/CxxPropertiesTestSuite.cc:
##########
@@ -52,14 +52,37 @@ TEST_F(CxxPropertiesTestSuite, testFillAndLoop) {
EXPECT_EQ(props.getAsBool("key5", false), true);
int count = 0;
+ for (auto it = props.begin(); it != props.end(); ++it) {
Review Comment:
The following range based test used a const ref, so uses `cbegin()` and
`cend()`. This way we test 2 styles and both the const and mutable variant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@celix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
