pnoltes commented on code in PR #470: URL: https://github.com/apache/celix/pull/470#discussion_r1388340942
########## libs/utils/src/properties.c: ########## @@ -17,55 +17,87 @@ * under the License. */ +#include "properties.h" +#include "celix_properties.h" +#include "celix_properties_private.h" + +#include <assert.h> +#include <errno.h> +#include <math.h> +#include <stdbool.h> #include <stdio.h> -#include <string.h> #include <stdlib.h> -#include <ctype.h> -#include <stdbool.h> +#include <string.h> -#include "properties.h" #include "celix_build_assert.h" -#include "celix_properties.h" +#include "celix_err.h" +#include "celix_string_hash_map.h" #include "celix_utils.h" -#include "utils.h" -#include "hash_map_private.h" -#include <errno.h> -#include "hash_map.h" +#include "celix_stdlib_cleanup.h" +#include "celix_convert_utils.h" -#define MALLOC_BLOCK_SIZE 5 +#define CELIX_SHORT_PROPERTIES_OPTIMIZATION_STRING_BUFFER_SIZE 512 Review Comment: I will make this configurable (as is done with `celix_err_buffer_size`) and set the default to 128. I also created a issue to #684 so that users can get some statistics about the service framework and use that to determine (if needed) the ideal properties optimization size for their use cases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@celix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
