Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1276#issuecomment-166668278
Did a code review on this PR and also talked to @michaelandersen on Slack
about switching the MASTER router off. With the changes he applied on the Java
file it will work fine.
Also checked the changes concerning the tests now covering KVM, Xen, VMware
and HyperV.
Code LGTM and awesome to see it covered by an integration test. Thanks a
lot!
:+1:
Will do some tests, but please check with @remibergsma @DaanHoogland
@miguelaferreira to give a second LGTM based on tests because I'm on holidays.
:)
Cheers,
Wilder
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
