Github user rodrigo93 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r52845493
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -172,6 +195,12 @@ private void validate(SnapshotInfo snapshotInfo) {
}
}
+ private boolean usingBackendSnapshotFor(SnapshotInfo snapshotInfo) {
+ String property = getProperty(snapshotInfo.getId(),
"takeSnapshot");
+
+ return Boolean.parseBoolean(property);
+ }
+
private Void handleCreateTemplateFromSnapshot(SnapshotInfo
snapshotInfo, TemplateInfo templateInfo,
AsyncCompletionCallback<CopyCommandResult> callback) {
--- End diff --
Hi @mike-tutkowski ,
Consider changing "Void" to "void" and removing the "return null;" at the
end of this method.
Another suggestion is to create a single method, if possible, for the lines
260 to 266 and 363 to 371, this would avoid some duplication of code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
