None of those individual commits should break CI. On Tuesday, February 16, 2016, DaanHoogland <g...@git.apache.org> wrote:
> Github user DaanHoogland commented on a diff in the pull request: > > https://github.com/apache/cloudstack/pull/1403#discussion_r53058692 > > --- Diff: > engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java > --- > @@ -172,6 +195,12 @@ private void validate(SnapshotInfo snapshotInfo) { > } > } > > + private boolean usingBackendSnapshotFor(SnapshotInfo > snapshotInfo) { > + String property = getProperty(snapshotInfo.getId(), > "takeSnapshot"); > + > + return Boolean.parseBoolean(property); > + } > + > private Void handleCreateTemplateFromSnapshot(SnapshotInfo > snapshotInfo, TemplateInfo templateInfo, > AsyncCompletionCallback<CopyCommandResult> callback) { > --- End diff -- > > @mike-tutkowski if commits are atomic and not breaking ci, yes, else, > no. Please use your own judgement. > > > --- > If your project is set up for it, you can reply to this email and have your > reply appear on GitHub as well. If your project does not have this feature > enabled and wishes so, or if the feature is enabled but not working, please > contact infrastructure at infrastruct...@apache.org <javascript:;> or > file a JIRA ticket > with INFRA. > --- > -- *Mike Tutkowski* *Senior CloudStack Developer, SolidFire Inc.* e: mike.tutkow...@solidfire.com o: 303.746.7302 Advancing the way the world uses the cloud <http://solidfire.com/solution/overview/?video=play>*™*
