Github user rodrigo93 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r53033391
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -172,6 +195,12 @@ private void validate(SnapshotInfo snapshotInfo) {
}
}
+ private boolean usingBackendSnapshotFor(SnapshotInfo snapshotInfo) {
+ String property = getProperty(snapshotInfo.getId(),
"takeSnapshot");
+
+ return Boolean.parseBoolean(property);
+ }
+
private Void handleCreateTemplateFromSnapshot(SnapshotInfo
snapshotInfo, TemplateInfo templateInfo,
AsyncCompletionCallback<CopyCommandResult> callback) {
--- End diff --
I see... Using "Void" instead of "void" is not a good programming practice
and should be "avoided" =P.
Another suggestion that I forgot to mention is to squash your commits into
one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
