Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1403#issuecomment-207536244
Can you rebase and give me a squashed commit for this?
Also, regarding the code. I have seen a lot of people cleaning up code to
remove the `_` in front of the variables. You seem to have done the opposite
in this PR and have actually added an `_` to variables in some cases. I am not
sure how we are handling this, but I suggest we start working toward a single
standard as it is confusing for me right now...
I will add this to my queue to run a full CI against it again.
Also, I am looking for two distinct LGTM for every PR, so I would like
another LGTM code review. Can someone from the dev list please give me a
review? Thx...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
