Github user mike-tutkowski commented on the pull request:
https://github.com/apache/cloudstack/pull/1403#issuecomment-207537423
Hi @swill - No problem for me to squash the commits, but are you sure you
want to lose the history of the individual commits?
Also, from what I've seen over the years, it seems more common to prefix
instance member variables with "_" than to not do so, but I'm not sure if we
have a coding guideline around that or not.
Can you clarify, too, if a LGTM has to come from a committer or can it be
any dev on the list?
If any dev on the list, we have Syed and I believe Gabriel (although I
didn't see a literal LGTM from him, but rather he provided his comments on the
code).
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
