Github user borisstoyanov commented on the pull request:
https://github.com/apache/cloudstack/pull/1489#issuecomment-216550819
Thanks @swill as Rohit mentioned we did migration testing of 4.8.1 to 4.9
without enabling the feature, to confirm users are able to continue using CS
without dynamic-checker. Then we executed the migration script and verified the
commands.properties are no longer available and all the rules are migrated in
the DB. This was performed with regular users as well as LDAP and SAML users.
Fresh installation of 4.9 was also tested, by default dynamic-checker is
enabled. Also regression testing was performed on creating and using custom
rules. My LGTM is up in the thread.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---