Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1678#discussion_r80064380 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java --- @@ -3300,7 +3301,7 @@ public boolean configureNetworkRulesVMSecondaryIP(final Connect conn, final Stri return false; } - final Script cmd = new Script(_securityGroupPath, _timeout, s_logger); + final Script cmd = new Script(_securityGroupPath, _timeout.getMillis(), s_logger); --- End diff -- Please consider adding an overridden version of the `Script(String, int, Logger)` constructor that accepts `Duration` to encapsulate this type conversion.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---