Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1678#discussion_r80064873
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtPvlanSetupCommandWrapper.java
---
@@ -58,11 +59,11 @@ public Answer execute(final PvlanSetupCommand command,
final LibvirtComputingRes
String result = null;
try {
final String guestBridgeName =
libvirtComputingResource.getGuestBridgeName();
- final int timeout = libvirtComputingResource.getTimeout();
+ final Duration timeout = libvirtComputingResource.getTimeout();
if (command.getType() == PvlanSetupCommand.Type.DHCP) {
final String ovsPvlanDhcpHostPath =
libvirtComputingResource.getOvsPvlanDhcpHostPath();
- final Script script = new Script(ovsPvlanDhcpHostPath,
timeout, s_logger);
+ final Script script = new Script(ovsPvlanDhcpHostPath,
timeout.getMillis(), s_logger);
--- End diff --
Please consider adding an overridden version of the `Script(String, int,
Logger)` constructor that accepts `Duration` to encapsulate this type
conversion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
