Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1678#discussion_r80065801
  
    --- Diff: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 ---
    @@ -1280,7 +1281,7 @@ public ExecutionResult executeInVR(String routerIP, 
String script, String args,
             try {
                 VmwareManager mgr = 
getServiceContext().getStockObject(VmwareManager.CONTEXT_STOCK_NAME);
                 result = SshHelper.sshExecute(routerIP, DefaultDomRSshPort, 
"root", mgr.getSystemVMKeyFile(), null, "/opt/cloud/bin/" + script + " " + args,
    -                    60000, 60000, timeout * 1000);
    +                    60000, 60000, (int)timeout.getMillis());
    --- End diff --
    
    Please consider adding an overridden version of the 
`SshHelper.sshExecute(String, int, String, String, ??, String, int, int, int)` 
method that accepts `Duration` to encapsulate this type conversion.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to