Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1678#discussion_r80064597
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtOvsCreateTunnelCommandWrapper.java
---
@@ -40,14 +40,11 @@ public Answer execute(final OvsCreateTunnelCommand
command, final LibvirtComputi
try {
if
(!libvirtComputingResource.findOrCreateTunnelNetwork(bridge)) {
s_logger.debug("Error during bridge setup");
- return new OvsCreateTunnelAnswer(command, false,
- "Cannot create network", bridge);
+ return new OvsCreateTunnelAnswer(command, false, "Cannot
create network", bridge);
}
-
libvirtComputingResource.configureTunnelNetwork(command.getNetworkId(),
command.getFrom(),
- command.getNetworkName());
-
- final Script scriptCommand = new
Script(libvirtComputingResource.getOvsTunnelPath(),
libvirtComputingResource.getTimeout(), s_logger);
+
libvirtComputingResource.configureTunnelNetwork(command.getNetworkId(),
command.getFrom(), command.getNetworkName());
+ final Script scriptCommand = new
Script(libvirtComputingResource.getOvsTunnelPath(),
libvirtComputingResource.getTimeout().getMillis(), s_logger);
--- End diff --
Please consider adding an overridden version of the `Script(String, int,
Logger)` constructor that accepts `Duration` to encapsulate this type
conversion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
